-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create NEST Extension Interface for NEST compatible with new registration scheme and unloading #3103
Conversation
Everything works now, including loading a modified module after |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for these changes! I tested this with modules generated from NESTML and the install works fine. I have a few comments. Please find them below.
@pnbabu Thank you for your review! I have fixed most items and commented on the two remaining. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor points and some questions still open.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Just some minor suggestions.
Co-authored-by: Dennis Terhorst <[email protected]>
Co-authored-by: Pooja Babu <[email protected]>
Co-authored-by: Pooja Babu <[email protected]>
@terhorstd Thanks for your comments! Could you take a look at my replies? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far. Thanks for the complex work!
The title says it all. This is still in draft stage as I need to iron out some problems, especially segfaults on
lt_dlclose()
of the module.ResetKernel()
works and one can install the module again afterwards, but I have not yet checked what happens if the module changes between reloads. At present, I need to provide the(DY)LD_LIBRARY_PATH
to the install location of the module. The oldDynamicLoader
is replaced byModuleManager
andNESTExtensionInterface
is the base class for extension modules.In nest/nest-extension-module#26 you will find a version of
mymodule
(in themodulemgr
branch) that works with this branch of NEST.This fixes #3064.