Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to deploy-on-release #790

Closed
2 tasks done
surchs opened this issue Sep 18, 2024 · 3 comments · Fixed by #802
Closed
2 tasks done

Move to deploy-on-release #790

surchs opened this issue Sep 18, 2024 · 3 comments · Fixed by #802
Assignees
Labels
maint:process Improvement to internal processes type:maintenance Upkeeping efforts & catch-up corrective improvements that are not Features nor Bugs

Comments

@surchs
Copy link
Contributor

surchs commented Sep 18, 2024

Recent events have shown us that deploying on every merge to main is risky, because you can deloy silly things at inopportune times. Let's follow the good examle of our dockerized tools and only deploy to prod on a release.

Specific todos:

  • Change our deployment process to only run on a release
  • Find a way to have a running "nightly" version with a persistent name (i.e. not the staging previews, but maybe netlify works)
  • [ ] Setup / carry over the auto-release workflow from other projects
@surchs surchs added type:maintenance Upkeeping efforts & catch-up corrective improvements that are not Features nor Bugs maint:process Improvement to internal processes flag:schedule Flag issue that should go on the roadmap or backlog. labels Sep 18, 2024
@rmanaem rmanaem removed the flag:schedule Flag issue that should go on the roadmap or backlog. label Sep 24, 2024
@surchs
Copy link
Contributor Author

surchs commented Oct 16, 2024

Let's not setup the auto-release. This repo is going to get its refactor in the not too distant future. So let's just release by hand for now and save ourselves the setup.

@rmanaem rmanaem self-assigned this Oct 25, 2024
@rmanaem
Copy link
Contributor

rmanaem commented Oct 25, 2024

Find a way to have a running "nightly" version with a persistent name (i.e. not the staging previews, but maybe netlify works)

@surchs Did you have something in mind for this?

We already have netlify on PRs here like we do in the query tool and the openneuro UI:
#798 (comment)

@surchs
Copy link
Contributor Author

surchs commented Oct 25, 2024

Yes @rmanaem, in fact the nightly builds (whatever the HEAD of main branch is) are already hosted here: https://neurobagel-annotator.netlify.app/ - we just never use that. Maybe we could link this deployment with a nice clear warning that it is unstable/can break from the repo description or README

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maint:process Improvement to internal processes type:maintenance Upkeeping efforts & catch-up corrective improvements that are not Features nor Bugs
Projects
Status: Review - Done
Development

Successfully merging a pull request may close this issue.

2 participants