Add cloud.aws.account_id config setting

[hmstepanek]

Overview

Add cloud.aws.account_id configuration setting. This is not used in this PR but will be used in future AWS linking for the user to provide the account_id when it cannot be derived by the instrumentation. See the Entity-Relationships agent spec.

[github-actions]

🦙 MegaLinter status: ❌ ERROR

Descriptor	Linter	Files	Fixed	Errors	Elapsed time
✅ PYTHON	bandit	2		0	6.57s
✅ PYTHON	black	3	1	0	2.31s
❌ PYTHON	flake8	3		1	1.16s
✅ PYTHON	isort	3	1	0	0.24s
✅ PYTHON	pylint	3		0	8.27s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by

[jairhenrique]

Suggested change

	if s and len(s) == 12:
	try:
	account_id = int(s)
	return account_id
	except ValueError:
	pass
	# Only log a warning if s is set.
	if s:
	_logger.warning(
	"Improper configuration. cloud.aws.account_id = %s will be ignored because it is not a 12 digit number.", s
	)
	return None
	if s and len(s) == 12 and s.isdigit():
	return int(s)
	# Only log a warning if s is set.
	if s:
	_logger.warning(
	f"Improper configuration. cloud.aws.account_id = {s} will be ignored because it is not a 12 digit number."
	)
	return None

[hmstepanek]

isdigit looks cool! It looks like it also returns true if there is a power digit like ² which would result in a ValueError still being raised by the int cast though.

>>> s="01234²34"
>>> s.isdigit()
True
>>> int(s)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ValueError: invalid literal for int() with base 10: '01234²34'

[jairhenrique]

@hmstepanek you can use s.isdecimal() instead!

In [1]: s="01234²34"

In [2]: s.isdecimal()
Out[2]: False

In [3]: s="01234234"

In [4]: s.isdecimal()
Out[4]: True

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.17%. Comparing base (f2cdd3e) to head (048e05b).

Files with missing lines	Patch %	Lines
newrelic/config.py	66.66%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1249      +/-   ##
==========================================
+ Coverage   81.15%   81.17%   +0.01%     
==========================================
  Files         200      200              
  Lines       21953    21971      +18     
  Branches     3479     3482       +3     
==========================================
+ Hits        17816    17834      +18     
- Misses       2986     2987       +1     
+ Partials     1151     1150       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests