fix(deps): ship vue and @nextcloud/vue as dependencies - #276
Merged
Conversation
Declaring them as peer dependencies meant a consumer had to provide Vue 3 itself, which a Vue 2 app cannot, and the dialog had to be reached through a bridge registered from a separate Vue 3 entry point. As dependencies they are installed with the library and nested where the consumer's own Vue is incompatible, so the dialog can be imported directly from a Vue 2 app — the same way @nextcloud/dialogs already does it. Both stay external in the build, so a consumer on a compatible version still gets a single deduped copy. @nextcloud/vue is raised to ^9.11.0, the first release in which the multiple recipient select renders at the same width as the other selects. Assisted-by: ClaudeCode:claude-opus-4-8 Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #276 +/- ##
=======================================
Coverage 79.91% 79.91%
=======================================
Files 27 27
Lines 727 727
Branches 202 202
=======================================
Hits 581 581
Misses 127 127
Partials 19 19 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
skjnldsv
marked this pull request as ready for review
September 8, 2026 13:41
skjnldsv
enabled auto-merge
September 8, 2026 13:42
susnux
reviewed
Sep 8, 2026
| "@nextcloud/vue": "^9.0.0", | ||
| "vue": "^3.5.0" | ||
| }, | ||
| "peerDependencies": {}, |
Contributor
There was a problem hiding this comment.
Suggested change
| "peerDependencies": {}, |
susnux
reviewed
Sep 8, 2026
| }, | ||
| "peerDependencies": {}, | ||
| "engines": { | ||
| "node": "^20.0.0 || ^22.0.0 || ^24.0.0" |
Contributor
There was a problem hiding this comment.
I would not put node 20 here
Suggested change
| "node": "^20.0.0 || ^22.0.0 || ^24.0.0" | |
| "node": "^22.0.0 || ^24.0.0 || >=26" |
susnux
approved these changes
Sep 8, 2026
This was referenced Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses susnux's review on nextcloud/server#62593: Vue 3 does run inside a Vue 2 app, as long as the library brings its own Vue.
vueand@nextcloud/vuewere peer dependencies, so a consumer had to supply Vue 3 itself. A Vue 2 app cannot, which is why the sharing dialog is reached from the files sidebar through anOCA.Sharingbridge. As dependencies they are installed with the library and npm nests them where the consumer's own Vue is incompatible, so the dialog can be imported directly — the same way@nextcloud/dialogsdoes it.@nextcloud/vuemoves to^9.11.0at the same time, the first release where the multiple recipient select renders at the same width as the other selects.Both stay external in the build:
dist/dialog.mjsstill importsvueand@nextcloud/vue/...rather than bundling them, so a consumer on a compatible version resolves to a single deduped copy. Once released, the server can drop the bridge.👾 This pull request was assisted by Claude Code, commits carry an
Assisted-bytrailer.