-
Notifications
You must be signed in to change notification settings - Fork 96
Add RichContenteditable component #1433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ae9e5e4 to
1acf5ed
Compare
d8519a6 to
9344467
Compare
9344467 to
3e35ecc
Compare
marcoambrosini
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that this is not working properly on netlify. I tried writing a sentence in there and new words are added on the left before the last word that I just typed. Maybe I'm doing something wrong?
Have you entered new lines? |
b41c3aa to
6904aaf
Compare
Good :-) But... how is it related to what to do when fetching the autocompletion results fail? :-)
|
Right, the wondrous land of content editable new lines :-P I initially tested with Firefox, and the text became |
because we add a space after a mention |
494af70 to
f651515
Compare
e362298 to
decd70c
Compare
|
Fixed:
Followups:
|
decd70c to
7058a9e
Compare
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
7058a9e to
d27ca50
Compare
|
Let's try to get this in and fix potentials small bugs later if possible, unless there is a complete breaking one still laying around (you never know 😁) |
julien-nc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't make a deep code review but it works fine from a user point of view!
v-modelhtml➡️textandtext➡️htmlfunctions in a mixin so anyone can render rich textInsights
The html generation method I used there (mounting the component, pulling the html and destroying) is actually quite fast!
For the biggest data sets it takes around
6msto render and pull. The first one is usually longer, after that it takes around1-2ms! 🚀Followup
https://github.com/Cobertos/vue-input-contenteditable doesn't support html rendering. So until then, let's keep it as plain text and see how we can improve from there.