Skip to content

fix(NcListItem): Add focus-visible outline state #4905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
susnux wants to merge 2 commits into from
Closed

fix(NcListItem): Add focus-visible outline state #4905

susnux wants to merge 2 commits into from

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Dec 1, 2023

☑️ Resolves

Add a focus-visible outline as the default one is not accessible (too low contrast).

🖼️ Screenshots

🏚️ Before 🏡 After
Screenshot 2023-12-01 at 17-50-47 Nextcloud Vue Style Guide Screenshot 2023-12-01 at 17-51-23 Nextcloud Vue Style Guide
Screenshot 2023-12-01 at 17-50-27 Nextcloud Vue Style Guide Screenshot 2023-12-01 at 17-51-51 Nextcloud Vue Style Guide

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

@susnux susnux added bug Something isn't working 3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities feature: list-item Related to the list-item component labels Dec 1, 2023
ShGKme
ShGKme reviewed Dec 1, 2023
View reviewed changes
@susnux susnux force-pushed the fix/nc-listitem-focus branch from e7e8521 to 3bba902 Compare December 1, 2023 17:50
@susnux susnux requested a review from ShGKme December 1, 2023 17:51
@susnux susnux force-pushed the fix/nc-listitem-focus branch from 3bba902 to e1ef586 Compare December 3, 2023 15:51
@ShGKme
Copy link
Contributor

ShGKme commented Dec 3, 2023

Styles seems to be overwritten by server styles:
https://github.com/nextcloud/server/blob/f778c6c34491031b5708bba786116dd72ec19aff/core/css/styles.scss#L36-L41

@susnux
Copy link
Contributor Author

susnux commented Dec 4, 2023

Styles seems to be overwritten by server styles:

There is a :not: see :not(#content-vue). So they should not override them. But server stylings should be adjusted and probably should use the classname instead.

@ShGKme
Copy link
Contributor

ShGKme commented Dec 13, 2023

Styles seems to be overwritten by server styles:

There is a :not: see :not(#content-vue). So they should not override them. But server stylings should be adjusted and probably should use the classname instead.

Does it work for you on server?

JuliaKirschenheuter
JuliaKirschenheuter approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, please check the server styles for the possible conflicts

@susnux susnux modified the milestones: 8.5.1, 8.6.0 Jan 24, 2024
@Antreesy Antreesy modified the milestones: 8.6.0, 8.6.1 Jan 30, 2024
@ShGKme ShGKme modified the milestones: 8.6.1, 8.6.2 Feb 1, 2024
@susnux
Copy link
Contributor Author

susnux commented Feb 3, 2024

Resolved as part of #5198

@susnux susnux closed this Feb 3, 2024
@susnux susnux deleted the fix/nc-listitem-focus branch February 3, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JuliaKirschenheuter JuliaKirschenheuter JuliaKirschenheuter approved these changes

@raimund-schluessler raimund-schluessler Awaiting requested review from raimund-schluessler

@Pytal Pytal Awaiting requested review from Pytal

@ShGKme ShGKme Awaiting requested review from ShGKme

Assignees

No one assigned

Labels

3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities bug Something isn't working feature: list-item Related to the list-item component

Projects

None yet

Milestone

8.6.2

Development

Successfully merging this pull request may close these issues.

5 participants

@susnux @ShGKme @JuliaKirschenheuter @Antreesy