Skip to content

fix(NcListItem): Add focus-visible outline state #4905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
susnux wants to merge 2 commits into from
Closed

fix(NcListItem): Add focus-visible outline state #4905

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d1219d2
fix(NcListItem): Add focus-visible outline state
susnux Dec 1, 2023
e1ef586
fixup! Make sure element does not resize
susnux Dec 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/components/NcListItem/NcListItem.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -708,6 +708,7 @@ export default {
.list-item__wrapper {
position: relative;
width: 100%;
padding: 2px; // for inner focus-visible outline

&--active,
&:active,
Expand Down Expand Up @@ -738,11 +739,11 @@ export default {
position: relative;
flex: 0 0 auto;
justify-content: flex-start;
padding: 8px 10px;
padding: 6px 8px;
// Fix for border-radius being too large for 3-line entries like in Mail
// 44px avatar size / 2 + 8px padding, and 2px for better visual quality
border-radius: 32px;
margin: 2px 0;
border: 2px solid transparent; // to prevent resizing on focus-visible
width: 100%;
cursor: pointer;
transition: background-color var(--animation-quick) ease-in-out;
Expand All @@ -754,6 +755,11 @@ export default {
background-color: var(--color-background-hover);
}

&:focus-visible {
border: 2px solid var(--color-main-background); // to also add contrast on active state
outline: 2px solid var(--color-main-text);
}

&-content__wrapper {
display: flex;
align-items: center;
Expand Down