Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable28] fix/remote activity constructor #1813

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Oct 14, 2024

Backport of #1811

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@juliusknorr juliusknorr force-pushed the backport/1811/stable28 branch from c9c99c5 to e066cc7 Compare October 15, 2024 09:34
@juliusknorr juliusknorr marked this pull request as ready for review October 15, 2024 09:34
Copy link

cypress bot commented Oct 15, 2024

Activity    Run #2032

Run Properties:  status check passed Passed #2032  •  git commit 08e370b283: [stable28] fix/remote activity constructor
Project Activity
Run status status check passed Passed #2032
Run duration 01m 44s
Commit git commit 08e370b283: [stable28] fix/remote activity constructor
Committer backportbot[bot]
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 3
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 7

@juliusknorr juliusknorr merged commit f7f697c into stable28 Oct 16, 2024
51 checks passed
@juliusknorr juliusknorr deleted the backport/1811/stable28 branch October 16, 2024 08:46
@Altahrim Altahrim mentioned this pull request Oct 30, 2024
2 tasks
@juliusknorr
Copy link
Member

After an issue report i've noticed that stable28 does not need this patch as it still uses the private Job classes, c8248b0 which introduced the issue was only added in 29+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant