-
Notifications
You must be signed in to change notification settings - Fork 26
feat: Implement memories #422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
julien-nc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we need something in the frontend to toggle is_remembered for a session, right?
Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
…nAPI annotation Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
julien-nc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope you don't mind, I pushed a few commits to fix a typo and adjust the "update chat session" controller method.
Added, but it doesn't end up in the db, any idea why? |
|
Can you push your code? |
Signed-off-by: Jana Peper <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
marcoambrosini
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice that you've been able to do it like this in the end!
I would avoid complicating the default interface further and put this in the ... menu as an NcActionButton type="radio". It basically can behave like a switch
Screen.Recording.2025-12-16.at.16.14.16.mov
Feels like no one will ever see or use this then |
|
I hope you don't mind me pushing here. @janepie and me found out the custom setter was the issue. It somehow changes 0 to '' when updating the entity. It works fine with the magic setter method. |
…isRemembered and isSummaryUpToDate Signed-off-by: Julien Veyssier <[email protected]>
1460b53 to
1ef3c0f
Compare
…ssion's isRemembered and isSummaryUpToDate" This reverts commit 1ef3c0f.
Signed-off-by: Marcel Klehr <[email protected]>
mmh, I sort of agree. Hiding it in the ... menu makes it less likely for people to discover it :/ |
Copying from internal chat on the topic: |
Signed-off-by: Jana Peper <[email protected]>
Signed-off-by: Jana Peper <[email protected]>
@marcoambrosini We develop it for people to use it and we want it to be seen and used. Do you have any proposal for a location that is less "disruptive" and still visible? I changed the icon to the memory one (like that!), as it doesn't have a filled version I adapted the text to change to Remembered when clicked, wdyt?
|
|
Maybe a tradeoff would be to make the button "icon-only" (with the label becoming the html title) and add a NcActionCheclbox item in the dropdown menu. |





Depends on
But is backward compatible
UI: