fix(KeyController): Check subject before attempting to sign CSR #1312
+9
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artonge
force-pushed
the
artonge/fix/check_cn_befire_signing
branch
from
1934315 to
8993fbb
Compare
Signed-off-by: Louis Chmn <[email protected]>
artonge
force-pushed
the
artonge/fix/check_cn_befire_signing
branch
from
8993fbb to
99a21a8
Compare
susnux
reviewed
Dec 18, 2025
Contributor
susnux
left a comment
susnux
left a comment
There was a problem hiding this comment.
I saw this too this week, thanks for fixing :)
artonge
changed the title
Collaborator
Author
In my testing, it does not bring any significant perf improvement in case the subject is wrong. Have you experienced some issue, or simply supposed that it should better be done this way? |
Contributor
|
No I did not see any significant performance draw back, but this way is simply more logical :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.