Skip to content

fix(KeyController): Check subject before attempting to sign CSR #1312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
artonge wants to merge 1 commit into
base: master
Choose a base branch
from
+9 −5
Draft

fix(KeyController): Check subject before attempting to sign CSR #1312

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions lib/Controller/KeyController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
use OCP\AppFramework\Http;
use OCP\AppFramework\Http\DataResponse;
use OCP\AppFramework\OCS\OCSBadRequestException;
use OCP\AppFramework\OCS\OCSException;
use OCP\AppFramework\OCS\OCSForbiddenException;
use OCP\AppFramework\OCS\OCSNotFoundException;
use OCP\AppFramework\OCSController;
Expand Down Expand Up @@ -185,20 +186,23 @@ public function createPublicKey(string $csr): DataResponse {

try {
$subject = openssl_csr_get_subject($csr);

$cn = isset($subject['CN']) ? $subject['CN'] : '';
if ($cn !== $this->userId) {
throw new OCSForbiddenException($this->l10n->t('Common name (CN) does not match the current user'));
}

$publicKey = $this->signatureHandler->sign($csr);
} catch (BadMethodCallException $e) {
$this->logger->critical($e->getMessage(), ['exception' => $e, 'app' => $this->appName]);
throw new OCSBadRequestException($e->getMessage());
} catch (OCSException $e) {
throw $e;
} catch (Exception $e) {
$this->logger->critical($e->getMessage(), ['exception' => $e, 'app' => $this->appName]);
throw new OCSBadRequestException($this->l10n->t('Internal error'));
}

$cn = isset($subject['CN']) ? $subject['CN'] : '';
if ($cn !== $this->userId) {
throw new OCSForbiddenException($this->l10n->t('Common name (CN) does not match the current user'));
}

$this->keyStorage->setPublicKey($publicKey, $this->userId);

return new DataResponse(['public-key' => $publicKey]);
Expand Down
Loading