Migrate version tab to vue #26675

enochterrymize · 2021-04-21T06:26:44Z

Ref #20020

apps/files_versions/webpack.js

apps/files_versions/src/views/VersionTab.vue

apps/files_versions/src/files_versions_tab.js

skjnldsv · 2021-04-21T06:38:09Z

apps/files_versions/src/files_versions.js

-import './css/versions.css'
+import './versionmodel';
+import './versioncollection';
+import './versionstabview';


You can remove this since you're now providing your own tab.
But for the development phase, you can leave it so you will have 2 versions tab and you will be more at ease when comparing the two :)

I ll leave it for the development phase

skjnldsv · 2021-04-21T06:39:05Z

apps/files_versions/src/components/VersionEntry.vue

+  -->
+
+<template>
+	<li class="version-entry">


Please use a ListItemIcon component

skjnldsv · 2021-04-21T06:41:03Z

apps/files_versions/src/views/VersionTab.vue

+				this.version.fullPath = fullPath
+				this.version.fileId = fileId
+				this.version.name = name
+				this.version.timestamp = parseInt(moment(new Date(version.timestamp)).format('X'), 10)
+				this.version.id = OC.basename(version.href)
+				this.version.size = parseInt(version.size, 10)
+				this.version.user = user
+				this.version.client = client


What is this.version? It does not seems to be declared anyhere.
I assume there is some code missing or this is still a WIP? 🤔 😉

removed and updated in FileVersion Service

skjnldsv · 2021-04-21T06:42:03Z

apps/files_versions/src/views/VersionTab.vue

+				const fetchVersion = await axios.get(shareUrl, {
+					params: {
+						format,
+						path,
+					},
+				})


Are you not using the davClient service(s)?

FileVersion Service - 6368672

skjnldsv · 2021-04-27T08:01:21Z

apps/files_versions/src/components/VersionEntry.vue

+
+<template>
+	<ListItemIcon class="version-entry"
+		icon="icon-text"


The icon needs to be the mime type.
You can get it with the method: OC.MimeType.getIconUrl(mimetype).
It will return an url of the icon (to be used like the Avatar component: https://github.com/nextcloud/nextcloud-vue/blob/8d1dca2df1e7ee02b50b8b52355f801e6799220a/src/components/ListItemIcon/ListItemIcon.vue#L65)

e.g. OC.MimeType.getIconUrl('image/jpg')

skjnldsv · 2021-04-27T08:03:06Z

apps/files_versions/src/components/VersionEntry.vue

+				{{ version.timestamp }}Restore
+			</ActionButton>
+			<ActionButton icon="icon-delete" @click="alert('Delete')">
+				Download


Needs translation

skjnldsv · 2021-04-27T08:03:10Z

apps/files_versions/src/components/VersionEntry.vue

+		subtitle="< 1KB">
+		<Actions>
+			<ActionButton icon="icon-edit" @click="alert('Edit')">
+				{{ version.timestamp }}Restore


Needs translation

skjnldsv · 2021-04-27T08:05:46Z

apps/files_versions/src/files_versions_tab.js

+	if (OCA.Files && OCA.Files.Sidebar) {
+		OCA.Files.Sidebar.registerTab(new OCA.Files.Sidebar.Tab({
+			id: 'versions',
+			name: t('files_versions', 'version'),


Versions?

skjnldsv · 2021-04-27T08:07:21Z

apps/files_versions/src/services/FileVersion.js

+		details: true,
+	}, options))
+
+	return response.data.map(FileVersion)


FileVersion doesn't exists?

skjnldsv · 2021-04-27T08:08:00Z

apps/files_versions/src/services/Viewer.js

+import Videos from '../models/videos'
+import Audios from '../models/audios'
+
+export default class Viewer {


What is this file?

Its removed, it was just for reference

skjnldsv · 2021-04-27T08:08:51Z

apps/files_versions/src/views/VersionTab.vue

+
+			fileInfo: null,
+
+			currentUser: null,


removed and updated

skjnldsv · 2021-04-27T08:08:55Z

apps/files_versions/src/views/VersionTab.vue

+		setCurrentUser(user) {
+			this._currentUser = user
+		},


removed and updated

juliusknorr · 2021-04-27T09:09:31Z

.htaccess

 <IfModule pagespeed_module>
  ModPagespeed Off
 </IfModule>
+#### DO NOT CHANGE ANYTHING ABOVE THIS LINE ####


This change come from your development setup with a specific configuration, so please do not commit that

juliusknorr · 2021-04-27T09:23:37Z

apps/files_versions/src/services/FileVersion.js

 	const path = (this.fileInfo.path + '/' + this.fileInfo.name).replace('//', '/')
    // Fetch Version
-	const fetchVersion = await axios.get(shareUrl, {
+	const fetchFileVersions = await axios.get(shareUrl, {


This should not be needed as the request would need to be issued by the below call to the webdav client in order to get the list of versions with the following propfind request for example:

Yes removed and Updated

juliusknorr · 2021-04-27T09:24:35Z

apps/files_versions/src/files_versions_tab.js

+import { translate as t, translatePlural as n } from '@nextcloud/l10n'
+
+import VersionTab from '../../files_versions/src/views/VersionTab'
+import TabSections from '../../files_versions/src/services/TabSections'


What would this be about? There is not tab section service yet ;)

juliusknorr · 2021-04-27T09:27:10Z

apps/files_versions/src/views/VersionTab.vue

+                console.log(error);
+			}
+		}
+		mounted() {


mounted is not expected to be within the methods but at the root of the vue component object.

Ok it updated

Also, missing comma on 114

Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>

files_versions_tab

528a5fa

enochterrymize requested a review from skjnldsv April 21, 2021 06:27

skjnldsv reviewed Apr 21, 2021

View reviewed changes

apps/files_versions/webpack.js Outdated Show resolved Hide resolved

skjnldsv reviewed Apr 21, 2021

View reviewed changes

apps/files_versions/src/views/VersionTab.vue Outdated Show resolved Hide resolved

skjnldsv reviewed Apr 21, 2021

View reviewed changes

apps/files_versions/src/files_versions_tab.js Outdated Show resolved Hide resolved

skjnldsv reviewed Apr 21, 2021

View reviewed changes

apps/files_versions/src/files_versions_tab.js Show resolved Hide resolved

skjnldsv reviewed Apr 21, 2021

View reviewed changes

skjnldsv added 2. developing Work in progress enhancement feature: file sidebar Related to the file sidebar component feature: versions labels Apr 21, 2021

MorrisJobke changed the title ~~fix-migrate-tabs-to-vue#20020~~ Migrate version tab to vue Apr 21, 2021

MorrisJobke mentioned this pull request Apr 21, 2021

Migrate tabs to vue #20020

Closed

4 tasks

MorrisJobke assigned enochterrymize Apr 22, 2021

enochterrymize added 6 commits April 22, 2021 16:04

webpack added file_versions.js

46f77a7

used nextcloud/auth

539b301

sidebar tab declaration mandatory parameters added and removed unused

4a04a6a

used ListItemIcon component in VersionEntry Component

27ce9ab

FileVersion service

6368672

fetchFileVersions request update in VersionTab.vue

0f8a123

skjnldsv reviewed Apr 27, 2021

View reviewed changes

juliusknorr reviewed Apr 27, 2021

View reviewed changes

enochterrymize and others added 10 commits April 28, 2021 09:12

fetch file version done and Code Clean Up

ac5e556

VersionEntry Updated

aeddbb6

fixup! VersionEntry Updated

1ebb04d

Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>

Version Entry update and Version Download

758a348

Version Entry update

31697b9

Version Revert

ab9efa0

VersionEntry Download

cda48ad

VersionEntry Tooltip added

b075dec

Version Restore Update

4a7222c

Verion Revert

c1b56e9

skjnldsv closed this Jan 10, 2022

skjnldsv deleted the fix-migrate-tabs-to-vue#20020 branch January 10, 2022 08:58

Uh oh!

Migrate version tab to vue #26675

Migrate version tab to vue #26675

Uh oh!

Conversation

enochterrymize commented Apr 21, 2021 • edited by MorrisJobke Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

enochterrymize Apr 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

enochterrymize commented Apr 21, 2021 •

edited by MorrisJobke

Loading

enochterrymize Apr 22, 2021 •

edited

Loading

skjnldsv Apr 27, 2021 •

edited

Loading