Skip to content

Migrate version tab to vue #26675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
enochterrymize wants to merge 17 commits into from
Closed

Migrate version tab to vue #26675

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
528a5fa
files_versions_tab
enochterrymize Apr 21, 2021
46f77a7
webpack added file_versions.js
enochterrymize Apr 22, 2021
539b301
used nextcloud/auth
enochterrymize Apr 22, 2021
4a04a6a
sidebar tab declaration mandatory parameters added and removed unused
enochterrymize Apr 22, 2021
27ce9ab
used ListItemIcon component in VersionEntry Component
enochterrymize Apr 22, 2021
6368672
FileVersion service
enochterrymize Apr 23, 2021
0f8a123
fetchFileVersions request update in VersionTab.vue
enochterrymize Apr 23, 2021
ac5e556
fetch file version done and Code Clean Up
enochterrymize Apr 28, 2021
aeddbb6
VersionEntry Updated
enochterrymize May 6, 2021
1ebb04d
fixup! VersionEntry Updated
skjnldsv May 6, 2021
758a348
Version Entry update and Version Download
enochterrymize May 7, 2021
31697b9
Version Entry update
enochterrymize May 7, 2021
ab9efa0
Version Revert
enochterrymize May 10, 2021
cda48ad
VersionEntry Download
enochterrymize May 10, 2021
b075dec
VersionEntry Tooltip added
enochterrymize May 12, 2021
4a7222c
Version Restore Update
enochterrymize May 25, 2021
c1b56e9
Verion Revert
enochterrymize May 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/files_versions/src/services/FileVersion.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ export default async function(client) {
// TODO: replace with proper getFUllpath implementation of our own FileInfo model
const path = (this.fileInfo.path + '/' + this.fileInfo.name).replace('//', '/')
// Fetch Version
const fetchVersion = await axios.get(shareUrl, {
const fetchFileVersions = await axios.get(shareUrl, {
Copy link
Member

@juliusknorr juliusknorr Apr 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be needed as the request would need to be issued by the below call to the webdav client in order to get the list of versions with the following propfind request for example:

image

Copy link
Author

@enochterrymize enochterrymize Apr 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes removed and Updated

Copy link
Author

@enochterrymize enochterrymize Apr 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ac5e556

params: {
format,
path,
Expand Down
5 changes: 3 additions & 2 deletions apps/files_versions/src/views/VersionTab.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ import { generateRemoteUrl } from '@nextcloud/router'
import { ListItemIcon } from '@nextcloud/vue'
import VersionEntry from '../components/VersionEntry'
import FileVersion from "../services/FileVersion";
import fetchFileVersions from "../services/FileVersion";

export default {
name: 'VersionTab',
Expand Down Expand Up @@ -104,8 +105,8 @@ export default {
async getVersions() {
try {
this.loading = true
const fetchVersion = FileVersion(Client);
fetchVersion();
const fetchVersions = fetchFileVersions(this._fileInfo.get('id'));
fetchVersions();
}
catch(e){
console.log(error);
Expand Down