refactor: Add type-hinting to Node-API #55622
Open
+1,079
−1,608
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Slight API changes:
FileInfo::getId
andNode::getId
now both returns an int with -1 being an invalid fileid. PreviouslyFileInfo::getId
did return nullFileInfo::getChecksum
was documented as returning a string but would from time to time returns null. Now it only return a string or an empty string. The places were we were checking for returning null or empty string, are now only checking for empty stringapps/dav/lib/Connector/Sabre/Directory.php
which was a valid usecase for passing a null mountpoint and storage, which is now using a DummyMountPoint (new) and a FailedStorageTODO
Checklist
3. to review
, feature component)stable32
)