Skip to content

Conversation

CarlSchwan
Copy link
Member

@CarlSchwan CarlSchwan commented Oct 8, 2025

Summary

Slight API changes:

  • FileInfo::getId and Node::getId now both returns an int with -1 being an invalid fileid. Previously FileInfo::getId did return null
  • FileInfo::getChecksum was documented as returning a string but would from time to time returns null. Now it only return a string or an empty string. The places were we were checking for returning null or empty string, are now only checking for empty string
  • LazyFolder now doesn't have any method related to IRootFolder, these are now exclusively in LazyRoot
  • FileInfo requires a valid path, IMountPoint and IStorage in it's constructor. This was already the case before but not enforced and many unit tests were just passing null. There was also apps/dav/lib/Connector/Sabre/Directory.php which was a valid usecase for passing a null mountpoint and storage, which is now using a DummyMountPoint (new) and a FailedStorage

TODO

Checklist

@CarlSchwan CarlSchwan added this to the Nextcloud 33 milestone Oct 8, 2025
@CarlSchwan CarlSchwan added the 2. developing Work in progress label Oct 8, 2025
@CarlSchwan CarlSchwan self-assigned this Oct 8, 2025
@CarlSchwan CarlSchwan force-pushed the carl/node-api-typing branch from cf5c51c to ce0b6ee Compare October 8, 2025 11:09
Same for getETag

Signed-off-by: Carl Schwan <[email protected]>
@CarlSchwan CarlSchwan force-pushed the carl/node-api-typing branch from 23a6378 to b5fce71 Compare October 8, 2025 14:12
@CarlSchwan CarlSchwan marked this pull request as ready for review October 8, 2025 15:10
@CarlSchwan CarlSchwan requested review from nickvergessen, blizzz and a team as code owners October 8, 2025 15:10
@CarlSchwan CarlSchwan requested review from ArtificialOwl, provokateurin and sorbaugh and removed request for a team October 8, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant