Skip to content

Conversation

@salmart-dev
Copy link
Contributor

@salmart-dev salmart-dev commented Nov 19, 2025

Summary

This branch contains some changes to clean up the two mount providers of the app:

  • applies DRY in some of the most used functions
  • removes unnecessary array_values
  • splits big functions into multiple smaller functions to ease code navigation

The branch is part of this set of branches:

TODO

  • Consider removing the $validateShares flag, as technically it is a change needed for a child branch and is not a refactoring

Checklist

@salmart-dev salmart-dev added the 2. developing Work in progress label Nov 19, 2025
@salmart-dev salmart-dev self-assigned this Nov 19, 2025
@salmart-dev salmart-dev added this to the Nextcloud 33 milestone Nov 19, 2025
@salmart-dev salmart-dev force-pushed the refactor/files-sharing branch 2 times, most recently from ab0dc8c to 5b58935 Compare November 20, 2025 16:38
@salmart-dev salmart-dev changed the base branch from fix/directoryAsINodeByPath to master November 20, 2025 16:39
@salmart-dev salmart-dev force-pushed the refactor/files-sharing branch 3 times, most recently from b329f51 to 85d8df5 Compare November 26, 2025 08:57
@salmart-dev salmart-dev force-pushed the refactor/files-sharing branch from 85d8df5 to cfba3f8 Compare November 28, 2025 12:03
@salmart-dev salmart-dev added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Nov 28, 2025
@salmart-dev salmart-dev marked this pull request as ready for review November 28, 2025 12:04
@salmart-dev salmart-dev requested a review from a team as a code owner November 28, 2025 12:04
@salmart-dev salmart-dev requested review from Altahrim, ArtificialOwl, leftybournes and yemkareems and removed request for a team November 28, 2025 12:04
@AndyScherzinger AndyScherzinger merged commit 631f471 into master Nov 28, 2025
225 of 240 checks passed
@AndyScherzinger AndyScherzinger deleted the refactor/files-sharing branch November 28, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants