Skip to content

Conversation

@salmart-dev
Copy link
Contributor

@salmart-dev salmart-dev commented Sep 12, 2025

Summary

This branch introduces changes to setupForPath to implement a version that support authoritative mount providers.

TODO

  • Check if we ship without the changes for the INodeByPath implementation

Checklist

@salmart-dev salmart-dev changed the title Feature/54562/path specific fs setup Path specific Filesystem setup Sep 12, 2025
@salmart-dev salmart-dev force-pushed the fix/directoryAsINodeByPath branch from a1a6278 to cf952ce Compare September 16, 2025 08:08
@salmart-dev salmart-dev force-pushed the feature/54562/pathSpecificFSSetup branch from 7f95870 to 07f4028 Compare November 11, 2025 16:29
@salmart-dev salmart-dev changed the base branch from fix/directoryAsINodeByPath to master November 11, 2025 16:30
@github-actions
Copy link
Contributor

Possible performance regression detected

Show Output
An unhandled exception has been thrown:
TypeError: array_map(): Argument #2 ($array) must be of type array, null given in /home/runner/work/server/server/apps/profiler/lib/Command/Compare.php:35
Stack trace:
#0 /home/runner/work/server/server/apps/profiler/lib/Command/Compare.php(35): array_map()
#1 /home/runner/work/server/server/3rdparty/symfony/console/Command/Command.php(326): OCAProfilerCommandCompare->execute()
#2 /home/runner/work/server/server/core/Command/Base.php(218): SymfonyComponentConsoleCommandCommand->run()
#3 /home/runner/work/server/server/3rdparty/symfony/console/Application.php(1078): OCCoreCommandBase->run()
#4 /home/runner/work/server/server/3rdparty/symfony/console/Application.php(324): SymfonyComponentConsoleApplication->doRunCommand()
#5 /home/runner/work/server/server/3rdparty/symfony/console/Application.php(175): SymfonyComponentConsoleApplication->doRun()
#6 /home/runner/work/server/server/lib/private/Console/Application.php(187): SymfonyComponentConsoleApplication->run()
#7 /home/runner/work/server/server/console.php(91): OCConsoleApplication->run()
#8 /home/runner/work/server/server/occ(33): require_once('...')
#9 {main}

@salmart-dev salmart-dev force-pushed the feature/54562/pathSpecificFSSetup branch from 07f4028 to 89d174e Compare November 17, 2025 16:19
@salmart-dev salmart-dev changed the base branch from master to fix/directoryAsINodeByPath November 17, 2025 16:21
@salmart-dev salmart-dev force-pushed the fix/directoryAsINodeByPath branch from 754f4e5 to 4da6b5f Compare November 17, 2025 16:22
@salmart-dev salmart-dev force-pushed the feature/54562/pathSpecificFSSetup branch from 89d174e to 1d4abcd Compare November 19, 2025 16:06
@salmart-dev salmart-dev changed the base branch from fix/directoryAsINodeByPath to refactor/files-sharing November 19, 2025 16:12
@salmart-dev salmart-dev self-assigned this Nov 19, 2025
@salmart-dev salmart-dev added the 2. developing Work in progress label Nov 19, 2025
@salmart-dev salmart-dev added this to the Nextcloud 33 milestone Nov 19, 2025
@salmart-dev salmart-dev force-pushed the refactor/files-sharing branch 2 times, most recently from ab0dc8c to 5b58935 Compare November 20, 2025 16:38
@salmart-dev salmart-dev force-pushed the feature/54562/pathSpecificFSSetup branch 2 times, most recently from ae0c613 to cdc7233 Compare November 20, 2025 16:38
@salmart-dev salmart-dev force-pushed the refactor/files-sharing branch from 5b58935 to fd5de92 Compare November 20, 2025 16:39
@salmart-dev salmart-dev changed the base branch from refactor/files-sharing to fix/directoryAsINodeByPath November 20, 2025 16:39
@salmart-dev salmart-dev force-pushed the feature/54562/pathSpecificFSSetup branch from cdc7233 to 70b0ecc Compare November 20, 2025 16:39
@salmart-dev salmart-dev force-pushed the fix/directoryAsINodeByPath branch from d504579 to b5977e7 Compare November 20, 2025 17:23
@salmart-dev salmart-dev force-pushed the feature/54562/pathSpecificFSSetup branch from 70b0ecc to b94b74f Compare November 20, 2025 17:23
@salmart-dev salmart-dev force-pushed the fix/directoryAsINodeByPath branch from b5977e7 to 831e780 Compare November 26, 2025 09:06
@salmart-dev salmart-dev force-pushed the feature/54562/pathSpecificFSSetup branch from b94b74f to 7f26f7e Compare November 26, 2025 09:06
@salmart-dev salmart-dev requested review from sorbaugh and szaimen and removed request for a team December 10, 2025 10:51
@salmart-dev salmart-dev changed the base branch from fix/directoryAsINodeByPath to master December 10, 2025 10:51
@salmart-dev
Copy link
Contributor Author

CodeQL is stuck, probably because of switching target branch. I'll update the branch with rebase to see if the proper CodeQL checks run (should actually be CodeQL Advanced, and not CodeQL) 😫

Signed-off-by: Salvatore Martire <[email protected]>
replace array_reduce + array_merge with array_merge(...)
replace conditional assignment with ??=

Signed-off-by: Salvatore Martire <[email protected]>
IMountProviders implementing this interface will be able to take
advantage of authoritative mounts.

The function `getMountsFromMountPoints` will receive the path that
the provider is asked to set-up and an array of IMountProviderArgs
providing information regarding the stored mount points and the
file cache data for the related root. The mount provider should verify
the validity of the mounts and return IMountPoints related to them.

Signed-off-by: Salvatore Martire <[email protected]>
@salmart-dev salmart-dev force-pushed the feature/54562/pathSpecificFSSetup branch from 276eda8 to d14a032 Compare December 10, 2025 15:05
@salmart-dev salmart-dev merged commit aaf07ab into master Dec 10, 2025
223 of 236 checks passed
@salmart-dev salmart-dev deleted the feature/54562/pathSpecificFSSetup branch December 10, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Path specific file sytem setup

5 participants