Skip to content

Conversation

@Arsalanulhaq
Copy link

Summary

Adds a new application configuration display_documentation_link that allows hiding the developer documentation link in the app settings page.

Changes

  • Controller: Modified AppSettingsController::viewApps() to conditionally set appstoreDeveloperDocs based on the display_documentation_link configuration
  • Tests: Updated existing tests and added two new test cases to verify the conditional behavior

Configuration

  • Config key: settingsdisplay_documentation_link
  • Default value: true (documentation link is shown)
  • Values: "true" or "false" (as string)

Usage

Hide the documentation link:

occ config:app:set settings display_documentation_link --value="false"

Show the documentation link (default):

occ config:app:set settings display_documentation_link --value="true"

Checklist

@Arsalanulhaq Arsalanulhaq requested review from a team as code owners December 2, 2025 11:45
@Arsalanulhaq Arsalanulhaq requested review from Copilot, leftybournes, salmart-dev, skjnldsv, sorbaugh, szaimen and yemkareems and removed request for a team December 2, 2025 11:45

This comment was marked as abuse.

@Arsalanulhaq Arsalanulhaq force-pushed the feat/hide-developer-docs-conditionally branch from 212bc41 to 48e6ba0 Compare December 2, 2025 15:11
@Arsalanulhaq Arsalanulhaq changed the title Feat/hide developer docs conditionally Feat(settings): hide developer docs conditionally Dec 2, 2025
@Arsalanulhaq Arsalanulhaq changed the title Feat(settings): hide developer docs conditionally feat(settings): conditionally display developer documentation link based on configuration Dec 2, 2025
@szaimen szaimen requested review from susnux and removed request for szaimen December 2, 2025 15:17
@kesselb kesselb added enhancement 2. developing Work in progress labels Dec 4, 2025
Copy link
Contributor

@kesselb kesselb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your pr 🙏

@Arsalanulhaq Arsalanulhaq force-pushed the feat/hide-developer-docs-conditionally branch from 48e6ba0 to e69b649 Compare December 5, 2025 17:25
@Arsalanulhaq Arsalanulhaq requested a review from kesselb December 6, 2025 10:39
@printminion-co printminion-co force-pushed the feat/hide-developer-docs-conditionally branch from e69b649 to 9c46001 Compare December 8, 2025 13:22

This comment was marked as spam.

@printminion-co printminion-co force-pushed the feat/hide-developer-docs-conditionally branch from 9c46001 to 370c02e Compare December 8, 2025 13:31
@kesselb
Copy link
Contributor

kesselb commented Dec 8, 2025

Hi @Arsalanulhaq,

We would prefer to drop the link from the apps store rather than adding a configuration option for it.

@Arsalanulhaq
Copy link
Author

Arsalanulhaq commented Dec 10, 2025

Hi @Arsalanulhaq,

We would prefer to drop the link from the apps store rather than adding a configuration option for it.

Hi @kesselb
So, should we remove the generated developerDocsUrl link in AppsSettingsController.php and its usage in the AppStoreNavigation.vue file directly from the code? Is this link generated or used anywhere else? Because removing it will prevent users from seeing/navigating to the developer documentation.

@Arsalanulhaq Arsalanulhaq force-pushed the feat/hide-developer-docs-conditionally branch from 370c02e to 51ae765 Compare December 16, 2025 09:46
@Arsalanulhaq Arsalanulhaq force-pushed the feat/hide-developer-docs-conditionally branch 2 times, most recently from c662141 to c4eae96 Compare December 16, 2025 09:59
@Arsalanulhaq Arsalanulhaq requested a review from come-nc December 16, 2025 10:02
@github-actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@printminion-co printminion-co force-pushed the feat/hide-developer-docs-conditionally branch from c4eae96 to 272f936 Compare December 17, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants