refactor(pinia): migrate breakoutRoomsStore to Pinia 🍍 #11649
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Antreesy
added
2. developing
feature: frontend 🖌️
Antreesy
force-pushed
the
refactor/noid/migrate-breakout-store
branch
from
17d9d25 to
9cf9e1e
Compare
nickvergessen
modified the milestones:
v19.0.0-beta.3,
💞 Next Beta (29),
v19.0.0-beta.4
Signed-off-by: Maksim Sukharev <[email protected]>
Antreesy
force-pushed
the
refactor/noid/migrate-breakout-store
branch
from
9cf9e1e to
358a262
Compare
3 tasks
DorraJaouad
reviewed
Mar 25, 2024
Contributor
DorraJaouad
left a comment
DorraJaouad
left a comment
There was a problem hiding this comment.
Testing :
Participants are not in their right room.
Also, is it expected to return room-not-found when reassigning a participant to the room where you are currently joining the call?
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This was referenced Mar 25, 2024
Antreesy
force-pushed
the
refactor/noid/migrate-breakout-store
branch
from
358a262 to
fabb220
Compare
Signed-off-by: Maksim Sukharev <[email protected]>
Antreesy
force-pushed
the
refactor/noid/migrate-breakout-store
branch
from
fabb220 to
0b7330a
Compare
DorraJaouad
approved these changes
Mar 25, 2024
Contributor
DorraJaouad
left a comment
DorraJaouad
left a comment
There was a problem hiding this comment.
As follow-ups are there, this is ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
No visual changes
🚧 Tasks
🏁 Checklist