Skip to content

fix(avatars): show Talk-defined avatar thumbnails in modals #11811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Antreesy merged 3 commits into from
Mar 19, 2024
Merged

fix(avatars): show Talk-defined avatar thumbnails in modals #11811

Antreesy merged 3 commits into from
Mar 19, 2024

Conversation

@Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Mar 15, 2024 •
edited
Loading

☑️ Resolves

  • Fix inconsistent avatars in modals
    • Use modal-mask class from Vue library instead of talk-modal
  • Update classes for NcRichContenteditable (mention-bubble and autocomplete-result)
  • Fix dark mode for AvatarWrapper

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before ☀️ Light theme 🌑 Dark Theme
image image image
image image image
image image image

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • 🖥️ Tested with Desktop client or should not be risky for it

@Antreesy Antreesy added this to the 💞 Next Beta (29) milestone Mar 15, 2024
@Antreesy Antreesy requested a review from DorraJaouad March 15, 2024 11:13
@Antreesy Antreesy self-assigned this Mar 15, 2024
@Antreesy Antreesy force-pushed the fix/noid/group-avatars branch from f1fcfa7 to 620f377 Compare March 15, 2024 13:22
@Antreesy Antreesy changed the title fix(avatars): show Talk-defined avatars in NewConversationDialog fix(avatars): show Talk-defined avatar thumbnails in modals Mar 15, 2024
DorraJaouad
DorraJaouad reviewed Mar 16, 2024
View reviewed changes
@Antreesy Antreesy mentioned this pull request Mar 18, 2024
Merged
@nickvergessen nickvergessen mentioned this pull request Mar 18, 2024
Merged
@Antreesy Antreesy force-pushed the fix/noid/group-avatars branch from 620f377 to 4c3cb02 Compare March 19, 2024 09:21
@Antreesy Antreesy force-pushed the fix/noid/group-avatars branch from 4c3cb02 to 68b5a34 Compare March 19, 2024 09:44
DorraJaouad
DorraJaouad approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, everything is good.

@Antreesy Antreesy merged commit 31e8234 into main Mar 19, 2024
@Antreesy Antreesy deleted the fix/noid/group-avatars branch March 19, 2024 10:19
@Antreesy Antreesy mentioned this pull request Apr 15, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

Assignees

@Antreesy Antreesy

Labels

3. to review bug feature: frontend 🖌️ "Web UI" client

Projects

None yet

Milestone

v19.0.0-beta.3

Development

Successfully merging this pull request may close these issues.

3 participants

@Antreesy @DorraJaouad