Skip to content

Conversation

@DorraJaouad
Copy link
Contributor

@DorraJaouad DorraJaouad commented Apr 9, 2024

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

very soon soon not in 24 hours
image image image

Lobby screen:
image

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • 🖥️ Tested with Desktop client or should not be risky for it
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@DorraJaouad DorraJaouad added enhancement feature: frontend 🖌️ "Web UI" client feature: meetings 📅 Covering the webinary usecase incl. Lobby labels Apr 9, 2024
@DorraJaouad DorraJaouad added this to the 💙 Next Major (30) milestone Apr 9, 2024
@DorraJaouad DorraJaouad requested a review from Antreesy April 9, 2024 13:19
@DorraJaouad DorraJaouad self-assigned this Apr 9, 2024
@DorraJaouad DorraJaouad force-pushed the enh/12027/lobby-timezone branch from b5d859b to 446c797 Compare April 9, 2024 13:25
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works good.
But I'd expect to see similar relative numbers in moderator dialog, and lobby waiting page. Maybe we should align the appearance in both places?

image

@DorraJaouad DorraJaouad force-pushed the enh/12027/lobby-timezone branch 2 times, most recently from 4cd6756 to 9669a4c Compare April 12, 2024 07:35
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works good. Not sure that missing minutes issue is related to changes, as computed value is correct

@ShGKme
Copy link
Contributor

ShGKme commented Apr 16, 2024

Not sure that missing minutes issue is related to changes, as computed value is correct

It is managed by this server code. If we live-relative-timestampwant to render time manually by Talk, then we need to remove this live-relative-timestamp class. Otherwise, I'd say, we should use nextcloud-vue component.

https://github.com/nextcloud/server/blob/3ad4bbb09692b180971e024ffeaab1d81fe77e4e/core/src/init.js#L42-L50

@DorraJaouad DorraJaouad force-pushed the enh/12027/lobby-timezone branch from 5ff64b2 to 9da7524 Compare April 16, 2024 18:48
@DorraJaouad DorraJaouad force-pushed the enh/12027/lobby-timezone branch from 9da7524 to 1a526b5 Compare April 16, 2024 19:31
@DorraJaouad DorraJaouad merged commit bb37b78 into main Apr 16, 2024
@DorraJaouad DorraJaouad deleted the enh/12027/lobby-timezone branch April 16, 2024 19:49
@DorraJaouad
Copy link
Contributor Author

/backport to stable29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement feature: frontend 🖌️ "Web UI" client feature: meetings 📅 Covering the webinary usecase incl. Lobby

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show timezone when setting lobby time

5 participants