fix(NewMessage): make silent chat button appearance more obvious

[Antreesy]

☑️ Resolves

• Fix send without notification is not obvious enough #12008
  • Same appearance as for filters in LeftSidebar
  • Less text changes, to describe only ENABLED behavior

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before	🏡 After

🏁 Checklist

• 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
• 🖥️ Tested with Desktop client or should not be risky for it
• 🖌️ Design was reviewed, approved or inspired by the design team
• ⛑️ Tests are included or not possible
• 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

[nickvergessen]

I would go with a https://nextcloud-vue-components.netlify.app/#/Components/NcCheckboxRadioSwitch Standard Switch to make it more clear, but then we don't have the space/place for the bell icon anymore

[DorraJaouad]

Better approach 👍🏻. Until a new icon with small audio off on bottom right comes out
like this https://pictogrammers.com/library/mdi/icon/send-check/

[Antreesy]

NcCheckboxRadioSwitch

Not supported inside NcActions menu at the moment, so either this, or we might need to improvise

[nickvergessen]

How about only doing these simple 3 lines (or on top of your changes, but basically without touching the send icon)

diff --git a/src/components/NewMessage/NewMessage.vue b/src/components/NewMessage/NewMessage.vue
index 4b1e45c25..b1523e694 100644
--- a/src/components/NewMessage/NewMessage.vue
+++ b/src/components/NewMessage/NewMessage.vue
@@ -141,6 +141,9 @@
                        <!-- Send buttons -->
                        <template v-else>
                                <NcActions v-if="!broadcast" :container="container" force-menu>
+                                       <template #icon>
+                                               <BellOffIcon v-if="silentChat" :size="16" />
+                                       </template>
                                        <NcActionButton close-after-click
                                                :name="silentSendLabel"
                                                @click="toggleSilentChat">

Normal	Silent

[nickvergessen]

Could then even keep the normal send-icon to reduce complexity

Dismissing

[Antreesy]

How about only doing these simple 3 lines

If that wasn't a previous requirement to force three-dot there, that sounds like a better option for now

[nickvergessen]

If that wasn't a previous requirement to force three-dot there

I think adding a custom icon was just added later to the component. So not a requirement but a past-restriction

[jancborchardt]

Suggestion by @nickvergessen sounds good to me, also with keeping the send icon normal (not outline) to reduce complexity as the bell-off icon is already indicating it.

[Antreesy]

/backport to stable29