Skip to content

fix(NewMessage): make silent chat button appearance more obvious #12109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Antreesy merged 1 commit into from
Apr 15, 2024
Merged

fix(NewMessage): make silent chat button appearance more obvious #12109

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 10 additions & 20 deletions src/components/NewMessage/NewMessage.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,13 +141,16 @@
<!-- Send buttons -->
<template v-else>
<NcActions v-if="!broadcast" :container="container" force-menu>
<template #icon>
<BellOffIcon v-if="silentChat" :size="16" />
</template>
<NcActionButton close-after-click
:model-value="silentChat"
:name="silentSendLabel"
@click="toggleSilentChat">
{{ silentSendInfo }}
<template #icon>
<BellIcon v-if="silentChat" :size="16" />
<BellOffIcon v-else :size="16" />
<BellOffIcon :size="16" />
</template>
</NcActionButton>
</NcActions>
Expand All @@ -159,8 +162,7 @@
:aria-label="sendMessageLabel"
@click="handleSubmit">
<template #icon>
<SendVariantOutlineIcon v-if="silentChat" :size="18" />
<SendIcon v-else :size="16" />
<SendIcon :size="16" />
</template>
</NcButton>
</template>
Expand Down Expand Up @@ -190,13 +192,11 @@
<script>
import debounce from 'debounce'

import BellIcon from 'vue-material-design-icons/Bell.vue'
import BellOffIcon from 'vue-material-design-icons/BellOff.vue'
import CheckIcon from 'vue-material-design-icons/Check.vue'
import CloseIcon from 'vue-material-design-icons/Close.vue'
import EmoticonOutline from 'vue-material-design-icons/EmoticonOutline.vue'
import SendIcon from 'vue-material-design-icons/Send.vue'
import SendVariantOutlineIcon from 'vue-material-design-icons/SendVariantOutline.vue'

import { getCapabilities } from '@nextcloud/capabilities'
import { showError, showWarning } from '@nextcloud/dialogs'
Expand Down Expand Up @@ -258,13 +258,11 @@ export default {
NewMessageTypingIndicator,
Quote,
// Icons
BellIcon,
BellOffIcon,
CheckIcon,
CloseIcon,
EmoticonOutline,
SendIcon,
SendVariantOutlineIcon,
},

props: {
Expand Down Expand Up @@ -440,21 +438,13 @@ export default {
},

silentSendLabel() {
return this.silentChat
? t('spreed', 'Send with notification')
: t('spreed', 'Send without notification')
return t('spreed', 'Send without notification')
},

silentSendInfo() {
if (this.isOneToOne) {
return this.silentChat
? t('spreed', 'The participant will be notified about new messages')
: t('spreed', 'The participant will not be notified about new messages')
} else {
return this.silentChat
? t('spreed', 'Participants will be notified about new messages')
: t('spreed', 'Participants will not be notified about new messages')
}
return this.isOneToOne
? t('spreed', 'The participant will not be notified about new messages')
: t('spreed', 'Participants will not be notified about new messages')
},

showAttachmentsMenu() {
Expand Down