Skip to content

Conversation

@Antreesy
Copy link
Contributor

☑️ Resolves

  • Currently computed waits for $route to be updated. Since it's async, that delays interface update as well as some operations fail (as they're trying to proceed with old value)
  • Now update it fast. But composable feels a bit redundant,..

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

No visual changes

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Integrations with Files sidebar and other apps
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@DorraJaouad
Copy link
Contributor

Now update it fast. But composable feels a bit redundant,..

At this point, threadId can be just an item in global state (store)..

@ShGKme
Copy link
Contributor

ShGKme commented Aug 21, 2025

  • Currently computed waits for $route to be updated. Since it's async

Note: reaction on reactive ref is also async

@Antreesy Antreesy force-pushed the fix/noid/usegetthreadid branch from e0bae64 to fda552d Compare August 22, 2025 08:58
@Antreesy Antreesy requested a review from ShGKme August 22, 2025 08:59
@Antreesy Antreesy force-pushed the fix/noid/usegetthreadid branch from fda552d to fe4f02b Compare August 22, 2025 09:09
@Antreesy Antreesy merged commit 33c9354 into main Aug 22, 2025
53 checks passed
@Antreesy Antreesy deleted the fix/noid/usegetthreadid branch August 22, 2025 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants