Skip to content

Conversation

@Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Oct 20, 2025

☑️ Resolves

One of the cases to reproduce (may be something else):

  • add sleep(5) to ChatController#getMessageContext
  • join the room
  • post a message before contextRequest was finished loading
  • contextId shifted to a new message
  • contextRequest 1 is cancelled, polling is never started
  • contextRequest2 is started, no more new messages

With this PR:

  • use the same fallback to last read message + long polling
  • if context request was cancelled, we at least have:
  • lastMessage to show in the chat
  • lastReadMessageId to start polling from it

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Integrations with Files sidebar and other apps
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

 - fallback to last read message + long polling if context request was cancelled

Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy Antreesy added this to the 🍏 Next Major (33) milestone Oct 20, 2025
@Antreesy Antreesy requested a review from DorraJaouad October 20, 2025 17:24
@Antreesy Antreesy self-assigned this Oct 20, 2025
@Antreesy
Copy link
Contributor Author

/backport to stable32

@Antreesy Antreesy merged commit e4245a7 into main Oct 20, 2025
56 checks passed
@Antreesy Antreesy deleted the fix/15868/long-polling branch October 20, 2025 17:51
@Antreesy Antreesy added the feature: frontend 🖌️ "Web UI" client label Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants