Skip to content

Conversation

@Antreesy
Copy link
Contributor

☑️ Resolves

  • Fix Being muted blocks access to audio output settings #16631
    • Disabled state for toggle button should bring the device check dialog (as it was originally)
    • Imitate disabled appearance with no event prevention
    • In popover, hide input actions, if not allowed to enable in call, show only output

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image
image image
image image
image image
image

🚧 Tasks

  • Cases, when it's allowed, but not available? - navigator.mediaDevices.getUserMedia Promise is rejected, no output devices to show anyway

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Integrations with Files sidebar and other apps
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Being muted blocks access to audio output settings

2 participants