Skip to content

Chat previews now expanded with aspect ratio #4469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
PVince81 wants to merge 3 commits into from
Closed

Chat previews now expanded with aspect ratio #4469

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
64a2ae9
Chat previews now expanded with aspect ratio
PVince81 Oct 26, 2020
9cfa070
Expand image preview height to 384
PVince81 Oct 26, 2020
e513241
Center the loading spinner
PVince81 Oct 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions src/components/MessagesList/MessagesGroup/Message/MessagePart/FilePreview.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,9 +162,9 @@ export default {
}

const previewSize = Math.ceil(this.previewSize * window.devicePixelRatio)
return generateUrl('/core/preview?fileId={fileId}&x={width}&y={height}', {
// expand width but keep a max height
return generateUrl('/core/preview?fileId={fileId}&x=-1&y={height}&a=1', {
fileId: this.id,
width: previewSize,
height: previewSize,
})
},
Expand Down Expand Up @@ -290,14 +290,18 @@ export default {
object-fit: cover;
}

.loading {
display: inline-block;
height: 128px;
Copy link
Member

@nickvergessen nickvergessen Oct 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we once also discussed to use more height, e.g. 300? cc @jancborchardt
But not sure what the endpoint does if the image is actually smalled?

Copy link
Member Author

@PVince81 PVince81 Oct 26, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can check with it. otherwise there's a "mode=fill" option which I'm not sure what it does, might fit

Copy link
Member Author

@PVince81 PVince81 Oct 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested with a picture of 50x50 and the preview provider doesn't make it bigger.
However the image tag will scale it up, so it will have the same height as the other pictures:
image

Copy link
Member Author

@PVince81 PVince81 Oct 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay I found the ticket with the decision to make it 384px: #3746 (comment)

I'll adjust

Copy link
Member Author

@PVince81 PVince81 Oct 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with new height:
image

and for a wide image:
image

margin-left: 32px;
}

.preview {
display: block;
width: 128px;
display: inline-block;
height: 128px;
}
.preview-64 {
display: block;
width: 64px;
display: inline-block;
height: 64px;
}

Expand All @@ -308,7 +312,6 @@ export default {
overflow: hidden;
white-space: nowrap;
text-overflow: ellipsis;
margin-top: 4px;
}

&:not(.file-preview--viewer-available) {
Expand Down