Skip to content

Use ListItem component #5437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
PVince81 merged 6 commits into from
Jul 6, 2021
Merged

Use ListItem component #5437

PVince81 merged 6 commits into from
Jul 6, 2021

Conversation

@marcoambrosini
Copy link
Member

@marcoambrosini marcoambrosini commented Mar 29, 2021 •
edited
Loading

This removes AppContentListItem and adds the upstreamed ListItem component.
requres nextcloud-libraries/nextcloud-vue#616

Signed-off-by: Marco Ambrosini [email protected]

@marcoambrosini marcoambrosini requested a review from danxuliu March 29, 2021 12:30
@marcoambrosini marcoambrosini self-assigned this Mar 29, 2021
@marcoambrosini marcoambrosini added this to the 💖 Next Major (22) milestone Mar 29, 2021
@marcoambrosini marcoambrosini linked an issue Mar 29, 2021 that may be closed by this pull request
Upstream all modifications and components #5240
Closed
11 tasks
@marcoambrosini marcoambrosini removed a link to an issue Mar 29, 2021
Upstream all modifications and components #5240
Closed
11 tasks
@marcoambrosini marcoambrosini force-pushed the feature/noid/use-vue-list-item-component branch from a41387f to d71be00 Compare March 31, 2021 08:36
@marcoambrosini marcoambrosini force-pushed the feature/noid/use-vue-list-item-component branch from d71be00 to 290d2b4 Compare June 10, 2021 15:00
@nickvergessen
Copy link
Member

nickvergessen commented Jun 11, 2021

Jest / node12.x (pull_request) Failing after 1m — node12.x

@marcoambrosini marcoambrosini force-pushed the feature/noid/use-vue-list-item-component branch from 290d2b4 to 2eb68bd Compare June 18, 2021 09:39
@marcoambrosini marcoambrosini marked this pull request as ready for review June 18, 2021 10:32
nickvergessen
nickvergessen reviewed Jun 18, 2021
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good otherwise

@nickvergessen
Copy link
Member

nickvergessen commented Jun 18, 2021

await listedEls.at(3).find('a').trigger('click')

Jest fails

@nickvergessen nickvergessen marked this pull request as draft June 22, 2021 09:28
@nickvergessen
Copy link
Member

nickvergessen commented Jun 23, 2021 •
edited by marcoambrosini
Loading

@nickvergessen nickvergessen mentioned this pull request Jun 23, 2021
Closed
@nickvergessen nickvergessen mentioned this pull request Jun 25, 2021
Closed
@skjnldsv skjnldsv linked an issue Jun 25, 2021 that may be closed by this pull request
Replace local acli component with ListItem #5874
Closed
@marcoambrosini
Use vue list item component
a238577 
Signed-off-by: Marco Ambrosini <[email protected]>
@marcoambrosini
Fix tests
85551d4 
Signed-off-by: Marco Ambrosini <[email protected]>
@marcoambrosini
Highlight counter if mentioned
b842219 
Signed-off-by: Marco Ambrosini <[email protected]>
@marcoambrosini
Fix highlighted counter bug
7844fd8 
Signed-off-by: Marco Ambrosini <[email protected]>
@marcoambrosini
Fix searchable conversations bug
dceecb6 
Signed-off-by: Marco Ambrosini <[email protected]>
@marcoambrosini marcoambrosini force-pushed the feature/noid/use-vue-list-item-component branch from 4104787 to dceecb6 Compare July 6, 2021 15:46
@marcoambrosini
Fix tests
ca27e59 
Signed-off-by: Marco Ambrosini <[email protected]>
@marcoambrosini marcoambrosini marked this pull request as ready for review July 6, 2021 15:59
PVince81
PVince81 approved these changes Jul 6, 2021
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works 👍

@PVince81 PVince81 merged commit 7fd3c81 into master Jul 6, 2021
@PVince81 PVince81 deleted the feature/noid/use-vue-list-item-component branch July 6, 2021 17:55
@marcoambrosini
Copy link
Member Author

marcoambrosini commented Jul 29, 2021

/backport to stable22.1

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jul 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PVince81 PVince81 PVince81 approved these changes

@danxuliu danxuliu Awaiting requested review from danxuliu

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees

@marcoambrosini marcoambrosini

Labels

3. to review technical debt

Projects

None yet

Milestone

v13.0.0-rc.1

Development

Successfully merging this pull request may close these issues.

Replace local acli component with ListItem

4 participants

@marcoambrosini @nickvergessen @PVince81