Skip to content

Conversation

@ChristophWurst
Copy link
Member

Before

Bildschirmfoto vom 2021-06-23 09-57-23

After

Bildschirmfoto vom 2021-06-23 09-56-40

default: '',
},
subtitleText: {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally we could get the text from the slot contents but this turned out to be a non-trivial problem especially with Vue 3

@ChristophWurst ChristophWurst force-pushed the enhancement/conversation-subtitle-hover-title branch from 5d616fa to 360ee66 Compare June 23, 2021 08:00
@nickvergessen
Copy link
Member

I think we need to limit is somehow.

Bildschirmfoto von 2021-06-23 10-29-16

@nickvergessen
Copy link
Member

Conflicts with #5437

@ChristophWurst
Copy link
Member Author

I think we need to limit is somehow.

Looks good to me actually :)

Copy link
Member

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that shomething like this should be implemented on the listitem component in the nextcloud vue library

@skjnldsv
Copy link
Member

I think we need to limit is somehow.

Make it scroll :D

@nickvergessen nickvergessen marked this pull request as draft June 25, 2021 12:23
@nickvergessen nickvergessen added this to the 💖 Next Major (23) milestone Jun 25, 2021
@ChristophWurst
Copy link
Member Author

Guess this one won't make it.

@ChristophWurst ChristophWurst deleted the enhancement/conversation-subtitle-hover-title branch July 5, 2021 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants