Display voice message preview before uploading #5787
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Ambrosini <[email protected]>
marcoambrosini
added
3. to review
enhancement
feature: chat 💬
PVince81
reviewed
Jun 16, 2021
| let localUrl = '' | ||
| if (file.type === 'image/png' || file.type === 'image/gif' || file.type === 'image/jpeg') { | ||
| localUrl = URL.createObjectURL(file) | ||
| } else if (isVoiceMessage) { |
Member
There was a problem hiding this comment.
add this arg to the JSDoc and extend the unit test fileUploadStore.spec.js ?
Member
Author
There was a problem hiding this comment.
@PVince81 I'll create an issue for the tests and I'll look into it once I have finished all the urgent tasks
nickvergessen
approved these changes
Jun 17, 2021
Member
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
Works,but see request from vincent
marcoambrosini
deleted the
feature/noid/preview-voice-messages-before-uploading
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Marco Ambrosini [email protected]