-
Notifications
You must be signed in to change notification settings - Fork 509
Display voice message preview before uploading #5787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -170,7 +170,7 @@ export default { | |
| }, | ||
| }, | ||
|
|
||
| data: function() { | ||
| data() { | ||
| return { | ||
| text: '', | ||
| parsedText: '', | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -211,6 +211,8 @@ const actions = { | |
| let localUrl = '' | ||
| if (file.type === 'image/png' || file.type === 'image/gif' || file.type === 'image/jpeg') { | ||
| localUrl = URL.createObjectURL(file) | ||
| } else if (isVoiceMessage) { | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. add this arg to the JSDoc and extend the unit test fileUploadStore.spec.js ?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @PVince81 I'll create an issue for the tests and I'll look into it once I have finished all the urgent tasks |
||
| localUrl = file.localUrl | ||
| } else { | ||
| localUrl = OC.MimeType.getIconUrl(file.type) | ||
| } | ||
|
|
@@ -317,7 +319,7 @@ const actions = { | |
| for (const index in shareableFiles) { | ||
| const path = shareableFiles[index].sharePath | ||
| const temporaryMessage = shareableFiles[index].temporaryMessage | ||
| const metadata = JSON.stringify({ 'messageType': temporaryMessage.messageType }) | ||
| const metadata = JSON.stringify({ messageType: temporaryMessage.messageType }) | ||
| try { | ||
| const token = temporaryMessage.token | ||
| dispatch('markFileAsSharing', { uploadId, index }) | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.