Skip to content

Show the conversation subtitle on hover #5855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ChristophWurst wants to merge 1 commit into from
Closed

Show the conversation subtitle on hover #5855

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/components/LeftSidebar/ConversationsList/AppContentListItem/AppContentListItem.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
</span>
</div>
<div class="acli__content__line-two">
<span class="acli__content__line-two__subtitle">
<span class="acli__content__line-two__subtitle" :title="subtitleText">
<slot name="subtitle" />
</span>
<span class="acli__content__line-two__counter">
Expand Down Expand Up @@ -112,6 +112,11 @@ export default {
type: String,
default: '',
},

subtitleText: {
Copy link
Member Author

@ChristophWurst ChristophWurst Jun 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally we could get the text from the slot contents but this turned out to be a non-trivial problem especially with Vue 3

type: String,
default: undefined,
},
},
computed: {
isActive() {
Expand Down
1 change: 1 addition & 0 deletions src/components/LeftSidebar/ConversationsList/Conversation.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
:title="item.displayName"
:anchor-id="`conversation_${item.token}`"
:to="item.token ? { name: 'conversation', params: { token: item.token }} : ''"
:subtitle-text="conversationInformation"
:class="{ 'has-unread-messages': item.unreadMessages }"
@click="onClick">
<template #icon>
Expand Down