Skip to content

🗒️ Create text document within conversation #7491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nickvergessen merged 21 commits into from
Aug 31, 2022
Merged

🗒️ Create text document within conversation #7491

nickvergessen merged 21 commits into from
Aug 31, 2022

Conversation

@marcoambrosini
Copy link
Member

@marcoambrosini marcoambrosini commented Jun 22, 2022 •
edited by nickvergessen
Loading

Fix #5330

@marcoambrosini marcoambrosini force-pushed the feature/#5330/create-text-document-within-conversation branch from 39b3bbb to 9c4e34f Compare June 22, 2022 11:24
@marcoambrosini marcoambrosini self-assigned this Jun 22, 2022
@nickvergessen nickvergessen changed the title Feature/#5330/create text document within conversation Create text document within conversation Jun 29, 2022
@nickvergessen nickvergessen changed the title Create text document within conversation 🗒️ Create text document within conversation Jun 29, 2022
nickvergessen
nickvergessen requested changes Jun 29, 2022
View reviewed changes
@marcoambrosini marcoambrosini force-pushed the feature/#5330/create-text-document-within-conversation branch from 4158129 to 142d76a Compare July 12, 2022 10:07
zzzzzzxXxzzzzzz
zzzzzzxXxzzzzzz approved these changes Jul 24, 2022
View reviewed changes
Copy link

@zzzzzzxXxzzzzzz zzzzzzxXxzzzzzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QueryParserTokenManager

@nickvergessen
Copy link
Member

nickvergessen commented Jul 28, 2022

@marcoambrosini can you add a checkbox list at the top with what's missing?

@nickvergessen nickvergessen force-pushed the feature/#5330/create-text-document-within-conversation branch from 142d76a to e470517 Compare August 2, 2022 09:25
nickvergessen
nickvergessen reviewed Aug 2, 2022
View reviewed changes
@nickvergessen

This comment was marked as resolved.

Sign in to view
@nickvergessen nickvergessen force-pushed the feature/#5330/create-text-document-within-conversation branch from e470517 to 4b4366b Compare August 30, 2022 21:16
nickvergessen
nickvergessen reviewed Aug 30, 2022
View reviewed changes
src/components/MessagesList/MessagesGroup/Message/MessagePart/FilePreview.vue
const availableHandlers = OCA.Viewer.availableHandlers
for (let i = 0; i < availableHandlers.length; i++) {
if (availableHandlers[i]?.mimes?.includes(this.mimetype)) {
if (availableHandlers[i]?.mimes?.includes && availableHandlers[i].mimes.includes(this.mimetype)) {
Copy link
Member

@nickvergessen nickvergessen Aug 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might need backporting? Or is the richdocuments app broken only on my dev enviroment?

nickvergessen
nickvergessen requested changes Aug 30, 2022
View reviewed changes
@nickvergessen
Copy link
Member

nickvergessen commented Aug 31, 2022

Menu Modal
Bildschirmfoto vom 2022-08-31 07-55-56 Bildschirmfoto vom 2022-08-31 07-53-47

I have to admit that I just copied over the TemplatePreview component from the files app and copied all dependencies (3 js methods from private files JS code) into the place of the import, but it works

@nickvergessen nickvergessen self-assigned this Aug 31, 2022
@nickvergessen nickvergessen requested review from nickvergessen and removed request for Ivansss August 31, 2022 06:03
marcoambrosini and others added 18 commits August 31, 2022 08:15
@marcoambrosini @nickvergessen
Add service and ability to create and share a text file
bb67c6f 
Signed-off-by: Marco Ambrosini <[email protected]>
@marcoambrosini @nickvergessen
Add InputVue component
cc453b0 
Signed-off-by: Marco Ambrosini <[email protected]>
@marcoambrosini @nickvergessen
Add file creation dialog
01f3cea 
Signed-off-by: Marco Ambrosini <[email protected]>
@marcoambrosini @nickvergessen
Open text document
b32a4b7 
Signed-off-by: Marco Ambrosini <[email protected]>
@nickvergessen
Move all icons to material design
1b3578c 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Fix labels
53de079 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Improve error handling
e1f9b5a 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Load the template list from the files app
20e513b 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Fix rendering mimetype icons
bcf873e 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Create in the Talk folder
a2eaf48 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Make sure the file was created and open the viewer in place
07dfb7d 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Move to NcTextField
fa1157a 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Remove unused method
a811f2f 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Keep the sidebar visible
40a4ecd 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Fix select/focus of the text input
7de9341 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Shamelessly copy the good work of Skjnldsv from the files app
ade8623 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Add some padding between the template options and the other parts of …
4a3864f 
…the form

Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Center the buttons
5d3f41e 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen nickvergessen force-pushed the feature/#5330/create-text-document-within-conversation branch from dc41307 to 5d3f41e Compare August 31, 2022 06:16
nickvergessen
nickvergessen approved these changes Aug 31, 2022
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘 to get rid of the denied reivew, but now most of the code is owned by me, so let's review this together @marcoambrosini

@nickvergessen
Copy link
Member

nickvergessen commented Aug 31, 2022

Had a quick chat with @marcoambrosini and fixed the missing top margin without templates.
So merging now.

@nickvergessen
Copy link
Member

nickvergessen commented Aug 31, 2022

No PHP change, so I canceled drone.

Merging

@nickvergessen nickvergessen merged commit 2fb3ee8 into master Aug 31, 2022
@nickvergessen nickvergessen deleted the feature/#5330/create-text-document-within-conversation branch August 31, 2022 13:11
@Antreesy Antreesy mentioned this pull request Oct 21, 2024
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PVince81 PVince81 PVince81 left review comments

@nickvergessen nickvergessen nickvergessen approved these changes

@danxuliu danxuliu Awaiting requested review from danxuliu

+1 more reviewer

@zzzzzzxXxzzzzzz zzzzzzxXxzzzzzz zzzzzzxXxzzzzzz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@nickvergessen nickvergessen

@marcoambrosini marcoambrosini

Labels

4. to release enhancement feature: upload & shares & voice 📤🎙️ Sharing files into a chat and audio recordings high

Projects

💬 Talk team
Archived in project

Milestone

v15.0.0-beta.2

Development

Successfully merging this pull request may close these issues.

🗒️ Create empty text document within conversation

5 participants

@marcoambrosini @nickvergessen @PVince81 @zzzzzzxXxzzzzzz