Announce new setting sections with aria-live #7642
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
added
3. to review
bug
feature: settings ⚙️
Member
Author
|
I wonder if that also applies to sections that bring it accessible stuff (like I did now), or only stuff that is not interactable? Also there is a showSuccess which is now read out. We could add it to that as well, sounds like a solid approach with less impact if above question is answered with "only stuff that has no actions" |
marcoambrosini
approved these changes
Jul 26, 2022
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
force-pushed
the
bugfix/7622/announce-new-sections-with-aria-live
branch
from
bb14976 to
25f2159
Compare
nickvergessen
changed the title
Member
Author
|
Not needed as it's the reading order |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7622