Skip to content

Announce new setting sections with aria-live #7642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nickvergessen wants to merge 1 commit into from
Closed

Announce new setting sections with aria-live #7642

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/ConversationSettings/LinkShareSettings.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
<label for="link_share_settings_toggle_guests">{{ t('spreed', 'Allow guests') }}</label>
</div>
</div>
<div v-show="isSharedPublicly" class="app-settings-subsection">
<div v-show="isSharedPublicly" class="app-settings-subsection" aria-live="polite">
<div id="link_share_settings_password_hint" class="app-settings-section__hint">
{{ t('spreed', 'Set a password to restrict who can use the public link.') }}
</div>
Expand Down
2 changes: 1 addition & 1 deletion src/components/ConversationSettings/ListableSettings.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
@change="toggleListableUsers">
<label for="listable_settings_registered_users_checkbox">{{ t('spreed', 'Open conversation to registered users') }}</label>
</div>
<div v-if="listable !== LISTABLE.NONE" class="indent">
<div v-if="listable !== LISTABLE.NONE" class="indent" aria-live="polite">
<div id="moderation_settings_listable_conversation_hint" class="app-settings-section__hint">
{{ t('spreed', 'This conversation will be shown in search results') }}
</div>
Expand Down
2 changes: 1 addition & 1 deletion src/components/ConversationSettings/LobbySettings.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
<label for="moderation_settings_enable_lobby_checkbox">{{ t('spreed', 'Enable lobby') }}</label>
</div>
</div>
<div class="app-settings-subsection">
<div class="app-settings-subsection" aria-live="polite">
<div v-if="hasLobbyEnabled" id="moderation_settings_lobby_timer_hint" class="app-settings-section__hint">
{{ t('spreed', 'After the time limit the lobby will be automatically disabled.') }}
</div>
Expand Down