Skip to content

📦 Use vendor-bin and Mozart to separate dev from production dependencies #7757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nickvergessen merged 4 commits into from
Sep 1, 2022
Merged

📦 Use vendor-bin and Mozart to separate dev from production dependencies #7757

nickvergessen merged 4 commits into from
Sep 1, 2022

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Aug 17, 2022 •
edited
Loading

Better solution for #7492 following the pattern from the mail app.

Fix #7828

@nickvergessen nickvergessen added this to the 💚 Next Beta (25) milestone Aug 17, 2022
@nickvergessen
Copy link
Member Author

nickvergessen commented Aug 17, 2022

Seems we need to do the reverse way and only move out the dev binaries with their dependencies

@nickvergessen nickvergessen marked this pull request as draft August 17, 2022 09:10
@ChristophWurst ChristophWurst self-requested a review August 17, 2022 09:22
@nickvergessen nickvergessen force-pushed the techdebt/noid/vendor-bin branch from 09eb3f4 to 36cf5ad Compare September 1, 2022 07:09
@nickvergessen nickvergessen mentioned this pull request Sep 1, 2022
Closed
@nickvergessen nickvergessen force-pushed the techdebt/noid/vendor-bin branch from ca12106 to 1e4a850 Compare September 1, 2022 08:06
@nickvergessen nickvergessen mentioned this pull request Sep 1, 2022
Closed
29 tasks
@nickvergessen nickvergessen force-pushed the techdebt/noid/vendor-bin branch from 1e4a850 to ee785ce Compare September 1, 2022 08:54
@nickvergessen nickvergessen marked this pull request as ready for review September 1, 2022 08:57
@nickvergessen
Copy link
Member Author

nickvergessen commented Sep 1, 2022

Ready to review again

ChristophWurst
ChristophWurst approved these changes Sep 1, 2022
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@nickvergessen nickvergessen changed the title Use vendor-bin to separate dev from production dependencies Use vendor-bin and Mozart to separate dev from production dependencies Sep 1, 2022
@nickvergessen nickvergessen changed the title Use vendor-bin and Mozart to separate dev from production dependencies 📦 Use vendor-bin and Mozart to separate dev from production dependencies Sep 1, 2022
@nickvergessen nickvergessen merged commit c8b2409 into master Sep 1, 2022
@nickvergessen nickvergessen deleted the techdebt/noid/vendor-bin branch September 1, 2022 10:13
@juliusknorr juliusknorr mentioned this pull request Mar 15, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@danxuliu danxuliu Awaiting requested review from danxuliu

Assignees

No one assigned

Labels

3. to review technical debt

Projects

None yet

Milestone

v15.0.0-beta.2

Development

Successfully merging this pull request may close these issues.

Default signaling token algorithm might be unsupported

4 participants

@nickvergessen @ChristophWurst @danxuliu