Adjust filtering and sorting to the same way the dashboard frontend does #8151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
added
3. to review
bug
feature: api 🛠️
Member
Author
|
/backport to stable25 |
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
force-pushed
the
bugfix/8121/fix-dashboard-widget-content
branch
from
e85781a to
9f1a580
Compare
Signed-off-by: Joas Schilling <[email protected]>
vitormattos
approved these changes
Oct 12, 2022
| }) | ||
| if (importantRooms.length) { | ||
| // FIXME unread 1-1 conversations are not sorted like unread mentions in group chats |
Contributor
There was a problem hiding this comment.
Suggested change
| // FIXME unread 1-1 conversations are not sorted like unread mentions in group chats | |
| /** @todo FIXME unread 1-1 conversations are not sorted like unread mentions in group chats **/ |
What you think? Is best use the annotation and in a future we can search only by @toto to check all that we neet to pay attention and fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is still a minor bug now on the web.
1-1 chats with unread messages are not sorted together with group chats where you have been pinged.
But that is something for a follow up and the dashboard api for the clients is the expected way.
Fix #8121