-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In Google Batch, install GPU drivers for GPU VMs #5406
base: master
Are you sure you want to change the base?
Conversation
Also clean up some old logic for container options when using GPUs. These are now automatically handled by Google Cloud. Fixes nextflow-io#5372. Signed-off-by: Siddhartha Bagaria <[email protected]>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
plugins/nf-google/src/main/nextflow/cloud/google/batch/GoogleBatchTaskHandler.groovy
Show resolved
Hide resolved
plugins/nf-google/src/main/nextflow/cloud/google/batch/GoogleBatchMachineTypeSelector.groovy
Outdated
Show resolved
Hide resolved
plugins/nf-google/src/main/nextflow/cloud/google/batch/GoogleBatchTaskHandler.groovy
Show resolved
Hide resolved
Co-authored-by: Ben Sherman <[email protected]> Signed-off-by: Siddhartha Bagaria <[email protected]>
@siddharthab overall the changes make sense. I think we'll need to do some testing on our end to make sure the machine type selection still works with Fusion + SSD Can you confirm that it works for you with some GPU-enabled tasks? |
Signed-off-by: Siddhartha Bagaria <[email protected]>
Yes, I confirm that I tested the following configurations:
† Needed new logic in ‡ It looks like
|
@bentsherman The test failures seem unrelated to this change. Please let me know if you would like to see anything more in this PR. |
@bentsherman Any thoughts? |
Also clean up some old logic for container options when using GPUs.
These are now automatically handled by Google Cloud.
Fixes #5372.
Signed-off-by: Siddhartha Bagaria [email protected]