Report syntax error for unexpected character in gstring#7353
Open
bentsherman wants to merge 1 commit into
Open
Report syntax error for unexpected character in gstring#7353bentsherman wants to merge 1 commit into
bentsherman wants to merge 1 commit into
Conversation
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
✅ Deploy Preview for nextflow-docs canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #6883
Long ago, I simplified the lexer rules for GStrings to remove a hack inherited from the Groovy grammar. However, that caused certain syntax errors to not be caught, leading to weird runtime behavior
This PR adds the lexer rules necessary to complete the GString handling, so that cases like
"$/"are reported as invalid syntax rather than leading to silently incorrect behavior