Improve URL staging resilience with configurable retry cooldown and regression coverage - #7476
Open
MikeWLloyd wants to merge 1 commit into
Open
Improve URL staging resilience with configurable retry cooldown and regression coverage#7476MikeWLloyd wants to merge 1 commit into
MikeWLloyd wants to merge 1 commit into
Conversation
✅ Deploy Preview for nextflow-docs canceled.
|
pditommaso
force-pushed
the
master
branch
2 times, most recently
from
August 20, 2026 12:03
5f935c2 to
d1eae20
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves reliability for remote input staging (especially HTTP/HTTPS URLs such as raw GitHub links) by making retry cooldown configurable and refining retry classification for transient URL failures. It directly addresses #7475
Motivation
Module and CI tests that stage remote files can fail due to transient DNS/network issues (for example host resolution failures). While staging retries already existed, retry delay was hardcoded and some URL-related error shapes were treated too aggressively as non-retryable.
What changed
• New config key: filePorter.retryDelay
• Default: 250ms
• Existing filePorter.maxRetries behavior is preserved
• Replaced small hardcoded/random sleep with configured retry delay
• Retry log now includes the configured wait duration
• Keeps fast-fail behavior for clearly non-retryable conditions
• Allows retry for HTTP/HTTPS NoSuchFileException patterns that appear transient/wrapped
• Avoids retries for clear missing-resource signals (for example 404/not found)
• Retries transient HTTP NoSuchFileException and succeeds
• Retries transient DNS-like URL failure and succeeds
• Does not retry clear missing HTTP resource (fails immediately as expected)
Files touched
Testing
Passed:
Backward compatibility
Suggested reviewer focus