Remove unused namespace and variable for clj-kondo lint code #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a minor fix, but it keeps showing up as a warning in my projects when I run clj-kondo from the command line, and I'd like to fix it :) Steps to reproduce the problem: 1. Run `clj-kondo --lint "$(clojure -A:your:aliases -Spath)" --copy-configs --skip-lint` to install clj-kondo configuration for your deps in some project that also uses clerk. 2. Run `clj-kondo --lint .` in the project The output contains: ./.clj-kondo/nextjournal/clerk/nextjournal/clerk/viewer.clj_kondo:3:14: warning: namespace clojure.string is required but never used ./.clj-kondo/nextjournal/clerk/nextjournal/clerk/viewer.clj_kondo:5:33: warning: unused binding lang ./.clj-kondo/nextjournal/clerk/nextjournal/clerk/viewer.clj_kondo:5:43: warning: unused binding opts After this commit, the warnings go away
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor fix, but it keeps showing up as a warning in my projects when I run clj-kondo from the command line, and I'd like to fix it :)
Steps to reproduce the problem:
Run
clj-kondo --lint "$(clojure -A:your:aliases -Spath)" --copy-configs --skip-lintto install clj-kondo configuration for your deps in some project that also uses clerk.Run
clj-kondo --lint .in the projectThe output contains:
After this commit, the warnings go away