Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused namespace and variable for clj-kondo lint code #636

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Commits on Feb 19, 2024

  1. Remove unused namespace and variable for clj-kondo lint code

    This is a minor fix, but it keeps showing up as a warning in my
    projects when I run clj-kondo from the command line, and I'd like to
    fix it :)
    
    Steps to reproduce the problem:
    
    1. Run `clj-kondo --lint "$(clojure -A:your:aliases -Spath)" --copy-configs --skip-lint`
       to install clj-kondo configuration for your deps in some project
       that also uses clerk.
    
    2. Run `clj-kondo --lint .` in the project
    
    The output contains:
    
    ./.clj-kondo/nextjournal/clerk/nextjournal/clerk/viewer.clj_kondo:3:14: warning: namespace clojure.string is required but never used
    ./.clj-kondo/nextjournal/clerk/nextjournal/clerk/viewer.clj_kondo:5:33: warning: unused binding lang
    ./.clj-kondo/nextjournal/clerk/nextjournal/clerk/viewer.clj_kondo:5:43: warning: unused binding opts
    
    After this commit, the warnings go away
    vedang committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    98bfbb3 View commit details
    Browse the repository at this point in the history