Download latest main #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add explicit check for the latest `main` version by pulling all package files and then filtering for the `main` label and finding the max `version`.
Explicitly downloads the max `build_number` for available distributions so that we are using the latest build.
joverlee521
commented
May 23, 2023
devel/download-latest
Outdated
Comment on lines
11
to
18
| curl -fsSL https://api.anaconda.org/package/nextstrain/nextstrain-base/files | jq -r ' | ||
| map(select(.labels|index("main"))) | ||
| | map(select(.attrs.subdir == env.CONDA_SUBDIR)) | ||
| | .[0].download_url | ||
| | (max_by(.version) | .version) as $max_version | ||
| | . | ||
| | map(select(.version == $max_version)) | ||
| | max_by(.attrs.build_number) | ||
| | .download_url |
There was a problem hiding this comment.
This a was a fun way to learn more jq but please let me know if this is too convoluted or if there's better way do this 🙏
tsibley
requested changes
May 23, 2023
| curl -fsSL https://api.anaconda.org/release/nextstrain/nextstrain-base/latest | jq -r ' | ||
| .distributions | ||
| curl -fsSL https://api.anaconda.org/package/nextstrain/nextstrain-base/files | jq -r ' | ||
| map(select(.labels|index("main"))) |
There was a problem hiding this comment.
non-blocking
For boolean containment, jq has a contains() function.
There was a problem hiding this comment.
I decided against contains() because it returns true even for substring containments.
The following returns true:
jq 'contains(["ab"])' <<< '["abcde"]'
Thanks @tsibley for pointing out that `max_by` accepts an array of paths and will sort in order of the provided array. Co-authored-by: Thomas Sibley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Updates
devel/download-latestto pull themainlabeled package with the maxversionandbuild_numberso that our CI diffs of packages only compares against the latestmainversion.Related issue(s)
Similar to changes we made in the Nextstrain CLI (nextstrain/cli#280).
Fixes #26
Testing