Provide GNU coreutils in the runtime #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They're provided in our other runtimes (almost by happenstance, as part of the underlying OS image) and having them available in all runtimes makes it much easier to write portable programs without having to deal with GNU vs. BSD differences. Note that typically GNU coreutils would already be available in the Conda runtime on Linux (via the host system), but not the Conda runtime on macOS (unless installed separately, e.g. via Homebrew). So explicitly including GNU coreutils here increases consistency, isolation, and portability of the runtime. Related-to: <nextstrain/ingest#41>
|
I'm not super confident this doesn't break stuff since the pathogen-repo-ci is all "passing" but really doing nothing (c.f. nextstrain/.github#93). So I may address that first. |
Pathogens generally aren't yet ready for the new behaviour beyond v0. Related-to: <nextstrain/.github#93>
genehack
approved these changes
Jun 12, 2024
11 tasks
joverlee521
added a commit
to nextstrain/ingest
that referenced
this pull request
Jun 14, 2024
The GNU coreutils `sha256sum` is much faster than the custom Python implementation in this repo. We no longer have to worry about portability since GN coreutils has been added to our conda runtime.¹ ¹ <nextstrain/conda-base#70>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They're provided in our other runtimes (almost by happenstance, as part of the underlying OS image) and having them available in all runtimes makes it much easier to write portable programs without having to deal with GNU vs. BSD differences.
Note that typically GNU coreutils would already be available in the Conda runtime on Linux (via the host system), but not the Conda runtime on macOS (unless installed separately, e.g. via Homebrew). So explicitly including GNU coreutils here increases consistency, isolation, and portability of the runtime.
Related-to: nextstrain/ingest#41
Checklist