Update import_weekly_rosters method in __init__.py #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update import_weekly_rosters to check if "age" column was specified by user before computing it for return. NOTE: this will additionally provide a workaround for nflverse#75 for users that do not require "age" in the output, given that column's computation is causing the errors described in that issue.
Added None check for columns variable in weekly_import_rosters (before checking for presence of value in the list).
|
Resolved by #106. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update import_weekly_rosters to check if "age" column was specified by user before computing it for return. NOTE: this will additionally provide a workaround for #75 for users that do not require "age" in the output, given that column's computation is causing the errors described in that issue.