Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update import_weekly_rosters method in __init__.py #80

Closed
wants to merge 2 commits into from
Closed

Update import_weekly_rosters method in __init__.py #80

wants to merge 2 commits into from

Commits on Jan 14, 2024

  1. Update __init__.py 

    Update import_weekly_rosters to check if "age" column was specified by user before computing it for return. NOTE: this will additionally provide a workaround for nflverse#75 for users that do not require "age" in the output, given that column's computation is causing the errors described in that issue.
    @DylanKeyer
    DylanKeyer authored Jan 14, 2024
    Configuration menu
    Copy the full SHA
    b332f75 View commit details
    Browse the repository at this point in the history

  2. Update __init__.py 

    Added None check for columns variable in weekly_import_rosters (before checking for presence of value in the list).
    @DylanKeyer
    DylanKeyer authored Jan 14, 2024
    Configuration menu
    Copy the full SHA
    83d8e3b View commit details
    Browse the repository at this point in the history