Performance rewrite, i.e. nflseedR 2.0 #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is a big speed bump because dplyr bind_rows is slow at binding lists and data.table is a reverse dependency anyways
we need data.table for quick list binding and can use it to replace csv download with readr
and games data attributes modification for consistency
and save h2h in pkg environment h2h has a new structure and is now only holding games that are listed in double games
looks for problems only if .debug = TRUE allocates the problem vector for more speed uses cli to output problems needs some adjustments for data.table output
Merge remote-tracking branch 'origin' into dt-rewrite # Conflicts: # DESCRIPTION # NAMESPACE # NEWS.md # R/compute_conference_seeds.R # R/compute_division_ranks.R # R/compute_draft_order.R # R/nflseedR-package.R # R/utils.R # tests/testthat/test-ranks_seeds_draftorder.R
Merge branch 'dt-rewrite' of https://github.com/nflverse/nflseedR into dt-rewrite # Conflicts: # NAMESPACE # R/compute_conference_seeds.R
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is going to be a huge PR where I adjust a ton of stuff for efficiency by either using data.table or just redo some principles.
This is work in progress, needs serious checking, and shouldn't be merged until off season
It would probably be the best to rewrite every dplyr pipe in data.table to be able to drop dplyr but it is a ton of code and rewriting everything is a source for bugs.
So we might keep it hybrid data.table/dplyr. It is still significantly faster now
This branch is based off #36 and therefore holds some commits of that branch.
Tests will fail because some output data have data.table attributes now.fixedI think it's better to update the tests with snapshots anyways