Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance rewrite, i.e. nflseedR 2.0 #39

Merged
merged 48 commits into from
Aug 7, 2023
Merged

Performance rewrite, i.e. nflseedR 2.0 #39

merged 48 commits into from
Aug 7, 2023

Commits on Dec 9, 2022

  1. gotta include the environment to be able to evaluate expressions

    @mrcaseb
    mrcaseb committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    d3071da View commit details
    Browse the repository at this point in the history

  2. nflseedR version and finish time are useful sims params

    @mrcaseb
    mrcaseb committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    16cfa51 View commit details
    Browse the repository at this point in the history

  3. avoid future and dplyr in the combining loops 

    this is a big speed bump because dplyr bind_rows is slow at binding lists and data.table is a reverse dependency anyways
    @mrcaseb
    mrcaseb committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    adaf81c View commit details
    Browse the repository at this point in the history

  4. drop readr dependency and use data.table to load the fake schedule

    @mrcaseb
    mrcaseb committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    1e4705d View commit details
    Browse the repository at this point in the history

  5. start message improvements

    @mrcaseb
    mrcaseb committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    bd764fb View commit details
    Browse the repository at this point in the history

  6. dev version and dependency updates 

    we need data.table for quick list binding and can use it to replace csv download with readr
    @mrcaseb
    mrcaseb committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    ed5ec00 View commit details
    Browse the repository at this point in the history

  7. namespace

    @mrcaseb
    mrcaseb committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    abe9edd View commit details
    Browse the repository at this point in the history

  8. stop > cli_abort

    @mrcaseb
    mrcaseb committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    72e9618 View commit details
    Browse the repository at this point in the history

  9. reshape args

    @mrcaseb
    mrcaseb committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    259b9b3 View commit details
    Browse the repository at this point in the history

  10. transition to nflreadr

    @mrcaseb
    mrcaseb committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    fd01220 View commit details
    Browse the repository at this point in the history

  11. it's nowhere used anymore

    @mrcaseb
    mrcaseb committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    263a920 View commit details
    Browse the repository at this point in the history

  12. replace glue_collapse calls with cli

    @mrcaseb
    mrcaseb committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    fea1110 View commit details
    Browse the repository at this point in the history

  13. drop glue

    @mrcaseb
    mrcaseb committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    3e6876c View commit details
    Browse the repository at this point in the history

  14. drop crayon

    @mrcaseb
    mrcaseb committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    ff6521b View commit details
    Browse the repository at this point in the history

  15. drop curl and use nflreadr to load schedules

    @mrcaseb
    mrcaseb committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    33109f9 View commit details
    Browse the repository at this point in the history

  16. more message improvements 

    and games data attributes modification for consistency
    @mrcaseb
    mrcaseb committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    bea8661 View commit details
    Browse the repository at this point in the history

  17. avoid pipe

    @mrcaseb
    mrcaseb committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    0fa683f View commit details
    Browse the repository at this point in the history

  18. it's better to test this stuff

    @mrcaseb
    mrcaseb committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    52dd49a View commit details
    Browse the repository at this point in the history

  19. fix broken tail method in vignette

    @mrcaseb
    mrcaseb committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    a93f6b4 View commit details
    Browse the repository at this point in the history

  20. news bullets

    @mrcaseb
    mrcaseb committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    e7c0356 View commit details
    Browse the repository at this point in the history

  21. news update

    @mrcaseb
    mrcaseb committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    e2b352e View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2022

  1. avoid repeated double_games calls

    @mrcaseb
    mrcaseb committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    19cdfba View commit details
    Browse the repository at this point in the history

  2. catch data.tables

    @mrcaseb
    mrcaseb committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    f4fe2d6 View commit details
    Browse the repository at this point in the history

  3. import data.table, avoid function maksing through dplyr 

    drop tidyr
    @mrcaseb
    mrcaseb committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    17bea19 View commit details
    Browse the repository at this point in the history

  4. double games lives somewhere else

    @mrcaseb
    mrcaseb committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    9210660 View commit details
    Browse the repository at this point in the history

  5. create nflseedR environment

    @mrcaseb
    mrcaseb committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    3794072 View commit details
    Browse the repository at this point in the history

  6. drop tidyr increment version heavily because it's major

    @mrcaseb
    mrcaseb committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    ca1ac70 View commit details
    Browse the repository at this point in the history

  7. redocument

    @mrcaseb
    mrcaseb committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    d24eebb View commit details
    Browse the repository at this point in the history

  8. rewrite double games and h2h in data.table 

    and save h2h in pkg environment
h2h has a new structure and is now only holding games that are listed in double games
    @mrcaseb
    mrcaseb committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    d0d2208 View commit details
    Browse the repository at this point in the history

  9. gotta left_join and drop NAs because of the new structure of h2h

    @mrcaseb
    mrcaseb committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    7c18262 View commit details
    Browse the repository at this point in the history

  10. make process games available in pkg namespace and create a data.table… 

    … variant
    @mrcaseb
    mrcaseb committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    8d37e23 View commit details
    Browse the repository at this point in the history

  11. rewrite simulation aggregation in data.table

    @mrcaseb
    mrcaseb committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    47df85f View commit details
    Browse the repository at this point in the history

  12. make simulate week a separate function

    @mrcaseb
    mrcaseb committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    e4de132 View commit details
    Browse the repository at this point in the history

  13. new simulate week 

    looks for problems only if .debug = TRUE
allocates the problem vector for more speed
uses cli to output problems
needs some adjustments for data.table output
    @mrcaseb
    mrcaseb committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    0aaeafc View commit details
    Browse the repository at this point in the history

  14. avoid multiple double_games calls

    @mrcaseb
    mrcaseb committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    8f0c189 View commit details
    Browse the repository at this point in the history

  15. deprecate teams argument

    @mrcaseb
    mrcaseb committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    abaef2e View commit details
    Browse the repository at this point in the history

  16. compute teams from games with data.table

    @mrcaseb
    mrcaseb committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    275989b View commit details
    Browse the repository at this point in the history

  17. incorporate h2h from input or load it from environment

    @mrcaseb
    mrcaseb committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    fcd98cd View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2022

  1. run tests from local games file and test h2h

    @mrcaseb
    mrcaseb committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    73ae8b4 View commit details
    Browse the repository at this point in the history

  2. import lifecycle and redocument

    @mrcaseb
    mrcaseb committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    ab0226d View commit details
    Browse the repository at this point in the history

  3. avoid special data.table character

    @mrcaseb
    mrcaseb committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    794ac25 View commit details
    Browse the repository at this point in the history

  4. avoid namespace problems in summary method

    @mrcaseb
    mrcaseb committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    c4e2ccf View commit details
    Browse the repository at this point in the history

  5. more NSE notes wtf

    @mrcaseb
    mrcaseb committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    a137950 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2022

  1. Merge branch 'master' into dt-rewrite

    @mrcaseb
    mrcaseb authored Dec 20, 2022
    Configuration menu
    Copy the full SHA
    695a2d8 View commit details
    Browse the repository at this point in the history

  2. code format

    @mrcaseb
    mrcaseb committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    f47d672 View commit details
    Browse the repository at this point in the history

  3. merge master 

    Merge remote-tracking branch 'origin' into dt-rewrite

# Conflicts:
#	DESCRIPTION
#	NAMESPACE
#	NEWS.md
#	R/compute_conference_seeds.R
#	R/compute_division_ranks.R
#	R/compute_draft_order.R
#	R/nflseedR-package.R
#	R/utils.R
#	tests/testthat/test-ranks_seeds_draftorder.R
    @mrcaseb
    mrcaseb committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    3b43a28 View commit details
    Browse the repository at this point in the history

  4. fix conflicts 

    Merge branch 'dt-rewrite' of https://github.com/nflverse/nflseedR into dt-rewrite

# Conflicts:
#	NAMESPACE
#	R/compute_conference_seeds.R
    @mrcaseb
    mrcaseb committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    aabbb0b View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2023

  1. Merge branch 'master' into dt-rewrite

    @mrcaseb
    mrcaseb authored Aug 7, 2023
    Configuration menu
    Copy the full SHA
    2f36a01 View commit details
    Browse the repository at this point in the history