WIP - Bottom Sheet Sizing Can Be Smaller on MapView #202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FIXME: Can it self size, or do we always need the small view? Does Feed Item vs Location show different content?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIXME: Can it self size, or do we always need the small view? Does Feed Item vs Location show different content?
More investigation if we want to fix this issue with SwiftUI sheet presentation.
I assume previous 4.2.0 (4.0.7) logic was self sizing, but SwiftUI implementation is not.
WIP Logic allows a smaller detent, but we need to make sure all types of content fit within a smaller size, or we need logic to self-size this so we always display all the content without clipping it.
With 220 point height:
With .medium detent