Skip to content

WIP - Bottom Sheet Sizing Can Be Smaller on MapView #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
paulsolt-ofsw wants to merge 1 commit into
base: release/4.4.0
Choose a base branch
from
Draft

WIP - Bottom Sheet Sizing Can Be Smaller on MapView #202

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion Mage/Mixins/BottomSheetEnabled.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,13 @@ class BottomSheetMixin: NSObject, MapMixin {
let mageBottomSheet = SwiftUIViewController(swiftUIView: MageBottomSheet())
mageBottomSheet.modalPresentationStyle = .pageSheet
if let sheet = mageBottomSheet.sheetPresentationController {
sheet.detents = [.medium(), .large()]
sheet.detents = [
.medium(),
.large(),
.custom(resolver: { context in
return 220 // FIXME: Do we use all these custom sizes? Or should we pick one? ~220 is close to previous behavior. Why doesn't this "self size"?
})
]
}
self.bottomSheetEnabled.navigationController?.present(mageBottomSheet, animated: true, completion: nil)

Expand Down