cphd::FileHeader::DEFAULT_VERSION has to be const char* for existin…

…g Python bindings
ngageoint · Jun 19, 2023 · cfae945 · cfae945
1 parent 03ec8e6
commit cfae945
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/six/modules/c++/cphd/include/cphd/FileHeader.h b/six/modules/c++/cphd/include/cphd/FileHeader.h
@@ -40,7 +40,7 @@ namespace cphd
 class FileHeader final : public BaseFileHeader
 {
 public:
-    static const std::string DEFAULT_VERSION;
+    static const char* DEFAULT_VERSION; // `const char*` for existing Python bindings
 
     /*
      *  \func FileHeader

diff --git a/six/modules/c++/cphd/source/FileHeader.cpp b/six/modules/c++/cphd/source/FileHeader.cpp
@@ -31,7 +31,13 @@
 
 namespace cphd
 {
-const std::string FileHeader::DEFAULT_VERSION = to_string(Version::v101);
+
+static const char* getDefaultVersion()
+{
+    static const auto defaultVersion = to_string(Version::v101);
+    return defaultVersion.c_str();
+}
+const char* FileHeader::DEFAULT_VERSION = getDefaultVersion();
 
 FileHeader::FileHeader() :
     mVersion(DEFAULT_VERSION),